From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_io: enable missing functions
Date: Thu, 3 Dec 2009 12:00:59 -0500 [thread overview]
Message-ID: <20091203170059.GC6894@infradead.org> (raw)
In-Reply-To: <4B16AE64.5080700@sandeen.net>
On Wed, Dec 02, 2009 at 12:13:56PM -0600, Eric Sandeen wrote:
> madvise and mincore were never hooked up to init_commands().
>
> Further, there is no HAVE_INJECT test in the configure scripts,
> so just remove that test (and keep the existing unconditional
> inject_init() prototype.
Hmm, maybe Nathan still has an idea what it's for, probably some IRIX
build.
Anyway, the madvise and mincore wireup looks good. Note entirely sure
what they do in xfs_io, though - they're VM syscalls not filesystem and
don't cause I/O normally.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-12-03 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 18:13 [PATCH] xfs_io: enable missing functions Eric Sandeen
2009-12-03 17:00 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203170059.GC6894@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.