From: mbroz@sourceware.org <mbroz@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW tools/pvmove.c
Date: 3 Dec 2009 19:22:25 -0000 [thread overview]
Message-ID: <20091203192225.27023.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz at sourceware.org 2009-12-03 19:22:24
Modified files:
. : WHATS_NEW
tools : pvmove.c
Log message:
Fix pvmove test mode to not fail and do not poll.
Test mode should not fail nor try to poll non-existent devices.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1339&r2=1.1340
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/pvmove.c.diff?cvsroot=lvm2&r1=1.68&r2=1.69
--- LVM2/WHATS_NEW 2009/12/03 19:20:48 1.1339
+++ LVM2/WHATS_NEW 2009/12/03 19:22:24 1.1340
@@ -1,5 +1,6 @@
Version 2.02.57 -
====================================
+ Fix pvmove test mode to not fail and do not poll.
Fix error message if VG already exist in vgcreate.
Fix tools to use log_error when stopped by user.
Fix lvcreate --readahead.
--- LVM2/tools/pvmove.c 2009/11/03 15:50:44 1.68
+++ LVM2/tools/pvmove.c 2009/12/03 19:22:24 1.69
@@ -312,8 +312,10 @@
/* FIXME: Add option to use a log */
if (first_time) {
if (!_activate_lv(cmd, lv_mirr, exclusive)) {
- if (test_mode())
+ if (test_mode()) {
+ r = 1;
goto out;
+ }
/*
* Nothing changed yet, try to revert pvmove.
@@ -570,6 +572,9 @@
int pvmove_poll(struct cmd_context *cmd, const char *pv_name,
unsigned background)
{
+ if (test_mode())
+ return ECMD_PROCESSED;
+
return poll_daemon(cmd, pv_name, NULL, background, PVMOVE, &_pvmove_fns,
"Moved");
}
next reply other threads:[~2009-12-03 19:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 19:22 mbroz [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-26 8:01 LVM2 ./WHATS_NEW tools/pvmove.c mbroz
2010-01-27 13:29 mbroz
2011-09-27 17:29 agk
2012-03-13 20:21 agk
2012-03-26 20:32 mbroz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203192225.27023.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.