From: Mike Frysinger <vapier@gentoo.org>
To: David Howells <dhowells@redhat.com>
Cc: uclinux-dev@uclinux.org, linux-kernel@vger.kernel.org,
Greg Ungerer <gerg@uclinux.org>,
uclinux-dist-devel@blackfin.uclinux.org,
David McCullough <davidm@snapgear.com>
Subject: Re: [uClinux-dev] Re: [PATCH] FDPIC: respect PT_GNU_STACK exec markings when creating NOMMU stack
Date: Fri, 4 Dec 2009 05:26:46 -0500 [thread overview]
Message-ID: <200912040526.47709.vapier@gentoo.org> (raw)
In-Reply-To: <31066.1259919632@redhat.com>
[-- Attachment #1: Type: Text/Plain, Size: 482 bytes --]
On Friday 04 December 2009 04:40:32 David Howells wrote:
> Mike Frysinger <vapier@gentoo.org> wrote:
> > > + flush_icache_range(mm->brk, brk);
> > > return mm->brk = brk;
> > > }
> >
> > probably want mm->brk + brk for the second argument
>
> Ummm... Why? mm->brk and brk are both addresses - note the return
> statement where brk just gets assigned to mm->brk.
yeah, sorry. i was thinking sbrk where the argument is an increment, not a
new address.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2009-12-04 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 15:24 [PATCH] FDPIC: respect PT_GNU_STACK exec markings when creating NOMMU stack Mike Frysinger
2009-11-28 18:47 ` [uClinux-dev] " Mike Frysinger
2009-12-02 13:44 ` David Howells
2009-12-02 21:29 ` [uClinux-dev] " Mike Frysinger
2009-12-03 17:58 ` David Howells
2009-12-04 7:07 ` Mike Frysinger
2009-12-04 9:40 ` David Howells
2009-12-04 10:26 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912040526.47709.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=davidm@snapgear.com \
--cc=dhowells@redhat.com \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.