From: "J. Bruce Fields" <bfields@citi.umich.edu>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: [PATCH 6/7] nfsd: restrict filehandles accepted in V4ROOT case
Date: Fri, 4 Dec 2009 13:49:59 -0500 [thread overview]
Message-ID: <20091204184959.GA19236@fieldses.org> (raw)
In-Reply-To: <4B192525.4050301-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
On Fri, Dec 04, 2009 at 10:05:09AM -0500, Steve Dickson wrote:
>
>
> On 12/01/2009 07:39 PM, J. Bruce Fields wrote:
> > + /*
> > + * A pseudoroot export gives permission to access only one
> > + * single directory; the kernel has to make another upcall
> > + * before granting access to anything else under it:
> > + */
> > + if (unlikely(dentry->d_parent != exp->ex_path.dentry))
> Remember this is wrong... it needs to be
> - if (unlikely(dentry->d_parent != exp->ex_path.dentry))
> + if (unlikely(dentry != exp->ex_path.dentry))
Oops, thanks. Looking back through the git reflogs.... It seems that I
had this fix in a separate patch, was rebasing the series and squashing
that patch in at the same time, and missed this chunk. Fixed in my
local version.
--b.
prev parent reply other threads:[~2009-12-04 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 0:39 pseudoroot kernel patches J. Bruce Fields
2009-12-02 0:39 ` [PATCH 1/7] nfsd: introduce export flag for v4 pseudoroot J. Bruce Fields
2009-12-02 0:39 ` [PATCH 2/7] nfsd4: don't continue "under" mounts in V4ROOT case J. Bruce Fields
2009-12-02 0:39 ` [PATCH 3/7] nfsd: filter lookup results " J. Bruce Fields
2009-12-02 0:39 ` [PATCH 4/7] nfsd: special readdir exception for V4ROOT J. Bruce Fields
2009-12-02 0:39 ` [PATCH 5/7] nfsd: allow exports of symlinks J. Bruce Fields
2009-12-02 0:39 ` [PATCH 6/7] nfsd: restrict filehandles accepted in V4ROOT case J. Bruce Fields
2009-12-02 0:39 ` [PATCH 7/7] nfsd: increase export interface version J. Bruce Fields
2009-12-04 15:05 ` [PATCH 6/7] nfsd: restrict filehandles accepted in V4ROOT case Steve Dickson
[not found] ` <4B192525.4050301-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2009-12-04 18:49 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091204184959.GA19236@fieldses.org \
--to=bfields@citi.umich.edu \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.