From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NGfHG-0004xU-84 for mharc-grub-devel@gnu.org; Fri, 04 Dec 2009 16:01:22 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NGfHC-0004wN-S2 for grub-devel@gnu.org; Fri, 04 Dec 2009 16:01:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NGfH7-0004uG-O2 for grub-devel@gnu.org; Fri, 04 Dec 2009 16:01:17 -0500 Received: from [199.232.76.173] (port=47789 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGfH7-0004uD-Kg for grub-devel@gnu.org; Fri, 04 Dec 2009 16:01:13 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:50724 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NGfH5-0003Kn-Os for grub-devel@gnu.org; Fri, 04 Dec 2009 16:01:13 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NGfGy-0003hT-HH for grub-devel@gnu.org; Fri, 04 Dec 2009 22:01:04 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NGfGy-0000W6-0p for grub-devel@gnu.org; Fri, 04 Dec 2009 22:01:04 +0100 Date: Fri, 4 Dec 2009 22:01:04 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091204210104.GG1528@thorin> References: <20091204155853.GA30900@thorin> <4B1937A2.60005@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4B1937A2.60005@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: mips/*/time.h X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2009 21:01:19 -0000 On Fri, Dec 04, 2009 at 05:24:02PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Robert Millan wrote: > > Hi, > > > > In mips branch grub_cpu_idle() is provided by grub/mips/yeeloong/time.h > > and grub/mips/qemu-mips/time.h, but there's no grub/mips/time.h. > > > > This breaks mipsel-emu port, which lacks this definition. Why not merge > > mips/yeeloong/time.h and mips/qemu-mips/time.h into mips/time.h ? Both > > files are identical. > > > > > Both are stubs actually. Why does *-emu needs these files at all? *-emu > doesn't see this type of machine info. It should just use host function > for both cpu_idle and get_rtc grub_cpu_idle is implemented as an inline stub, which resides in time.h. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."