From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NGfIV-00066j-OP for mharc-grub-devel@gnu.org; Fri, 04 Dec 2009 16:02:39 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NGfIT-000653-Tg for grub-devel@gnu.org; Fri, 04 Dec 2009 16:02:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NGfIP-0005wo-AV for grub-devel@gnu.org; Fri, 04 Dec 2009 16:02:37 -0500 Received: from [199.232.76.173] (port=47833 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGfIP-0005wg-7C for grub-devel@gnu.org; Fri, 04 Dec 2009 16:02:33 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:50726 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NGfIO-0003Ri-KE for grub-devel@gnu.org; Fri, 04 Dec 2009 16:02:32 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NGfIJ-0003hb-WC for grub-devel@gnu.org; Fri, 04 Dec 2009 22:02:28 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NGfIJ-0000WF-D5 for grub-devel@gnu.org; Fri, 04 Dec 2009 22:02:27 +0100 Date: Fri, 4 Dec 2009 22:02:27 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091204210227.GH1528@thorin> References: <1259181468.2806.15.camel@fz.local> <4B104397.4060806@gmail.com> <20091128190101.GA25683@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20091128190101.GA25683@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: grub_halt() X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2009 21:02:38 -0000 On Sat, Nov 28, 2009 at 08:01:01PM +0100, Robert Millan wrote: > On Fri, Nov 27, 2009 at 10:24:39PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > Felix Zielcke wrote: > > > grub_halt is on i386-pc defined as `void grub_halt (int no_apm)' but > > > everywhere else as `grub_halt (void)' > > > util/grub-emu.c has a #ifdef for these 2 > > > > > > Shouldn't we just add an int parameter everywhere to make this more > > > simple? > > > > > > > > I think in future we'll have more different halt methods on different > > platforms. So we could do: > > grub_halt (int methods) > > And have e.g. > > GRUB_HALT_DEFAULT_METHODS > > And e.g. on i386: > > #define GRUB_HALT_DEFAULT_METHODS > > (GRUB_HALT_APM|GRUB_HALT_ACPI|GRUB_HALT_HANG) > > I was hoping we could remove complexity rather than add more of it. > > Why would higher layer (who's just calling grub_halt because it wants the > system to shutdown) want to know about things like APM or ACPI ? Well, for now I just unified the headers but kept the current i386-pc function parameters. This restores experimental to a buildable state. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."