Re: [PATCH 1/4]: OMAP: ZOOM: Introducing 'board-zoom-flash.c' for NAND init in ZOOM boards

[Tony Lindgren <tony@atomide.com>]

* Grazvydas Ignotas <notasas@gmail.com> [091203 08:05]:
> On Thu, Dec 3, 2009 at 4:15 PM, Vimal Singh <vimal.newwork@gmail.com> wrote:
> > From 948584f4157a9eb99ba085968d23add28cbfd160 Mon Sep 17 00:00:00 2001
> > From: Vimal Singh <vimalsingh@ti.com>
> > Date: Tue, 1 Dec 2009 11:36:56 +0530
> > Subject: [PATCH] OMAP: ZOOM: Introducing 'board-zoom-flash.c'
> >
> > This patch adds 'board-zoom-flash.c', which could be utilized
> > by boards similar to ZOOM2. (For ex: LDP, ZOOM2, ZOOM3).
> 
> So it's not really zoom specific, i.e. can be used by other boards
> with NAND like beagleboard and pandora? If that's the case, perhaps
> the file could be named something like omap3-nand.c or simply just
> nand.c .
> 
> >
> > This does initialization for NAND device based on the 'cs' number
> > and partition information passed from board file (ex: board-zoom2.c).
> >
> > Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> > ---
> >  arch/arm/mach-omap2/board-zoom-flash.c        |   59 +++++++++++++++++++++++++
> >  arch/arm/mach-omap2/include/mach/board-zoom.h |   11 +++++
> >  2 files changed, 70 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/arm/mach-omap2/board-zoom-flash.c
> >
> > diff --git a/arch/arm/mach-omap2/board-zoom-flash.c
> > b/arch/arm/mach-omap2/board-zoom-flash.c
> > new file mode 100644
> > index 0000000..b3e66ca
> > --- /dev/null
> > +++ b/arch/arm/mach-omap2/board-zoom-flash.c

<snip>

> > +void __init zoom_flash_init(struct flash_partitions zoom_nand_parts[], int cs)
> > +{
> > +       u32 gpmc_base_add = OMAP34XX_GPMC_VIRT;
> > +
> > +       zoom_nand_data.cs               = cs;
> > +       zoom_nand_data.parts            = zoom_nand_parts[0].parts;
> > +       zoom_nand_data.nr_parts         = zoom_nand_parts[0].nr_parts;
> > +       zoom_nand_data.gpmc_baseaddr    = (void *)(gpmc_base_add);
> > +       zoom_nand_data.gpmc_cs_baseaddr = (void *)(gpmc_base_add +
> > +                                               GPMC_CS0_BASE +
> > +                                               cs * GPMC_CS_SIZE);
> > +       gpmc_nand_init(&zoom_nand_data);
> > +}

And here too you should use gpmc_cs_request().

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html