From: Ralf Baechle <ralf@linux-mips.org>
To: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 1/3] [MIPS] mipssim: remove unused code
Date: Sat, 5 Dec 2009 10:41:58 +0000 [thread overview]
Message-ID: <20091205104158.GA11800@linux-mips.org> (raw)
In-Reply-To: <1255546939-3302-2-git-send-email-dmitri.vorobiev@movial.com>
On Wed, Oct 14, 2009 at 10:02:17PM +0300, Dmitri Vorobiev wrote:
> The function prom_init_cmdline() doesn't do anything, and nobody calls
> the prom_getcmdline() function. Since these two are the only functions
> in the file arch/mips/mipssim/sim_cmdline.c, the whole file can be
> removed now along with the call to the no-op prom_init_cmdline()
> routine.
>
> Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
And obviously not compile tested:
CC arch/mips/mipssim/sim_int.o
make[3]: *** No rule to make target `arch/mips/mipssim/sim_cmdline.o', needed by `arch/mips/mipssim/built-in.o'. Stop.
make[2]: *** [arch/mips/mipssim] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
Ralf
next prev parent reply other threads:[~2009-12-05 10:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 19:02 [PATCH 0/3] A few cleanups for MIPS code Dmitri Vorobiev
2009-10-14 19:02 ` [PATCH 1/3] [MIPS] mipssim: remove unused code Dmitri Vorobiev
2009-10-15 9:49 ` Ralf Baechle
2009-12-05 10:41 ` Ralf Baechle [this message]
2009-12-05 12:09 ` [PATCH] [MIPS] Fix MIPSsim build after command-line cleanup Dmitri Vorobiev
2009-12-19 22:07 ` Ralf Baechle
2009-12-20 5:03 ` Dmitri Vorobiev
2009-10-14 19:02 ` [PATCH 2/3] [MIPS] msp71xx: remove unused function Dmitri Vorobiev
2009-10-14 23:16 ` Shane McDonald
2009-10-14 23:25 ` Ralf Baechle
2009-10-15 3:57 ` Shane McDonald
2009-10-14 19:02 ` [PATCH 3/3] [MIPS] remove an unused header file Dmitri Vorobiev
2009-10-14 19:12 ` Manuel Lauss
2009-10-14 19:17 ` Dmitri Vorobiev
2009-10-14 19:37 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091205104158.GA11800@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dmitri.vorobiev@movial.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.