From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NHGsp-0004EN-Oh for mharc-grub-devel@gnu.org; Sun, 06 Dec 2009 08:10:39 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHGsn-0004Cg-9p for grub-devel@gnu.org; Sun, 06 Dec 2009 08:10:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHGsg-00047k-91 for grub-devel@gnu.org; Sun, 06 Dec 2009 08:10:34 -0500 Received: from [199.232.76.173] (port=53135 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHGsf-00046l-Co for grub-devel@gnu.org; Sun, 06 Dec 2009 08:10:29 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:39617 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NHGsf-0002zr-3N for grub-devel@gnu.org; Sun, 06 Dec 2009 08:10:29 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NHGsc-00049m-LO; Sun, 06 Dec 2009 14:10:26 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NHGsc-0006Qp-3G; Sun, 06 Dec 2009 14:10:26 +0100 Date: Sun, 6 Dec 2009 14:10:26 +0100 From: Robert Millan To: David Miller Message-ID: <20091206131026.GA24598@thorin> References: <20091206.012146.124293458.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091206.012146.124293458.davem@davemloft.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: grub-devel@gnu.org Subject: Re: Broken common.rmk change X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Dec 2009 13:10:37 -0000 On Sun, Dec 06, 2009 at 01:21:46AM -0800, David Miller wrote: > > Robert, the set of objects used to build grub-mkdevicemap on > sparc64-ieee1275 is not the same as those used on other architectures. > So this change was not correct: > > 2009-11-26 Robert Millan > > * conf/common.rmk (sbin_UTILITIES): Add `grub-mkdevicemap'. > ... > * conf/i386-coreboot.rmk (sbin_UTILITIES): Remove `grub-mkdevicemap'. > (grub_mkdevicemap_SOURCES): Remove. > ... > * conf/sparc64-ieee1275.rmk: Likewise. > > In particular, we use a special implementation devicemap.c on > sparc64-ieee1275 so that openfirmware device nodes are emitted instead > of "hd0" et al. > > So when you moved the build rule into common.rmk you broke this. > > This is probably the primary reason that the current tree works for > nobody on sparc64 :-) > > Before I found this problem, I tested with an existing devicemap and > config file on a Niagara LDOM Linux guest and current trunk worked as > well as it did when I was last active several months ago and I was > able to boot Linux kernels with it. We're actually in the process of getting rid of device.map; in fact the "hd0" names you see have no real effect on i386-pc, they're just ignored. We now have more robust code that doesn't hardcode drive names. grub-setup now accepts plain system devices as arguments, even if they're not listed in device.map. grub-mkconfig generates a grub.cfg that relies on UUIDs instead of hardcoding, etc. But I might have missed some detail. Is there a peculiarity of sparc64-ieee1275 that makes this approach unpractical? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."