All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sebastian Kapfer <sebastian_kapfer@gmx.net>
Cc: Linux Input ML <linux-input@vger.kernel.org>
Subject: Re: [alps] Timing patch, revised again :-)
Date: Sun, 6 Dec 2009 12:09:57 -0800	[thread overview]
Message-ID: <20091206200957.GA18820@core.coreip.homeip.net> (raw)
In-Reply-To: <1260129237.21632.7.camel@sardelle.necksus.de>

On Sun, Dec 06, 2009 at 08:53:57PM +0100, Sebastian Kapfer wrote:
> > 
> > Ah, ok, so when we report all 3 buttons pressed we mistaken it as interleaved 
> > packet again... Insteado f waiting till 9th byte can't we just forcefully
> > exit inetrleaved mode (once we processed the bare packet) by doing:
> > 
> >      psmouse->packet[3] &= 0xf7;
> 
> Hmm I guess we could do something like this, but IMHO it makes the code
> needlessly arcane.  What would be the point?  Save 3 bytes of buffer?
> Deliver the mouse movement a microsecond earlier?

No, this allows us validate the data bytes as tehy come in and probably
detect desync right away and resync earlier.

-- 
Dmitry

  reply	other threads:[~2009-12-06 20:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-29 16:54 [alps] Timing patch, revised again :-) Sebastian Kapfer
2009-12-04  8:49 ` Dmitry Torokhov
2009-12-04 21:47   ` Sebastian Kapfer
2009-12-04 23:49     ` Dmitry Torokhov
2009-12-04 23:52       ` Dmitry Torokhov
2009-12-06 19:53       ` Sebastian Kapfer
2009-12-06 20:09         ` Dmitry Torokhov [this message]
2009-12-07  0:27           ` Sebastian Kapfer
2009-12-13 22:01     ` [PATCH 1/2] Sebastian Kapfer
2009-12-13 22:09     ` [PATCH 2/2] Alps Dualpoint, Interleaved packets Sebastian Kapfer
2009-12-15  6:42       ` Dmitry Torokhov
2009-12-15 21:01         ` Sebastian Kapfer
2009-12-15 22:49           ` Dmitry Torokhov
2009-12-16  0:01             ` Sebastian Kapfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091206200957.GA18820@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=sebastian_kapfer@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.