All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: dst_release() cleanup
Date: Mon, 7 Dec 2009 10:57:30 -0800	[thread overview]
Message-ID: <20091207105730.1fc14c4d@nehalam> (raw)
In-Reply-To: <4B1D4573.9040605@gmail.com>

On Mon, 07 Dec 2009 19:12:03 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> Stephen Hemminger a écrit :
>  
> > I don't like to put actual necessary code in WARN or BUG macro
> > args because some embedded type developer is likely to build
> > with
> > 
> > #define WARN_ON(x)
> > 
> > to get rid of all warnings.
> 
> Oops, I thought WARN_ON(X) must evaluate X once, my bad, since its not documented.
> 

If done correctly, it would. The correct way to ignore warnings would be to do
something like:

#define WARN_ON(x) (x)



  reply	other threads:[~2009-12-07 18:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-05 12:02 [PATCH] net: dst_release() cleanup Eric Dumazet
2009-12-07 17:17 ` Stephen Hemminger
2009-12-07 18:12   ` Eric Dumazet
2009-12-07 18:57     ` Stephen Hemminger [this message]
2009-12-07 18:59   ` Ilpo Järvinen
2009-12-07 19:13     ` Eric Dumazet
2009-12-09  4:35       ` David Miller
2009-12-09 21:46         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091207105730.1fc14c4d@nehalam \
    --to=shemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.