From: Andrew Morton <akpm@linux-foundation.org>
To: Veaceslav Falico <vfalico@redhat.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Al Viro <viro@zeniv.linux.org.uk>,
Miloslav Trmac <mitr@redhat.com>,
James Morris <jmorris@namei.org>, Alan Cox <alan@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Renaud Lottiaux <renaud.lottiaux@kerlabs.com>,
Louis Rilling <louis.rilling@kerlabs.com>,
David Howells <dhowells@redhat.com>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [PATCH v2 1/4] copy_signal cleanup: use zalloc and remove initializations
Date: Mon, 7 Dec 2009 12:36:15 -0800 [thread overview]
Message-ID: <20091207123615.fc841a83.akpm@linux-foundation.org> (raw)
In-Reply-To: <20091204142814.GH10052@darkmag.usersys.redhat.com>
On Fri, 4 Dec 2009 15:28:14 +0100
Veaceslav Falico <vfalico@redhat.com> wrote:
> Use kmem_cache_zalloc() on signal creation and remove unneeded initialization
> lines in copy_signal().
>
> Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
> ---
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 166b8c4..160477d 100644
> @@ -855,7 +844,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk)
For some reason this patch is missing its headers and doesn't apply.
I fixed that up and it still doesn't apply, because there are pending
changes in this area in -mm.
Normally I'd fix that up, but this one is looking a bit non-trivial, so
I'm afraid I'm going to ask you to redo the patches against
http://userweb.kernel.org/~akpm/mmotm/
Alternatively, we could just hold them off until 2.6.34. Wait until
2.6.33-rc1 is released then resend the patch series based on
2.6.33-rc1. Perhaps this is a better approach, as we are now in the
2.6.33 merge window and it's a bit late to be introducing new material.
Either way, please do ensure that the next patch series retains all the
acked-by:'s which people have sent.
Thanks.
next prev parent reply other threads:[~2009-12-07 20:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 22:10 [PATCH 1/4] copy_signal cleanup: use zalloc and remove initializations Veaceslav Falico
2009-12-02 13:57 ` Oleg Nesterov
2009-12-02 18:27 ` Veaceslav Falico
2009-12-04 14:28 ` [PATCH v2 " Veaceslav Falico
2009-12-05 16:25 ` Oleg Nesterov
2009-12-07 7:34 ` Balbir Singh
2009-12-07 20:36 ` Andrew Morton [this message]
2009-12-08 12:37 ` Veaceslav Falico
2009-12-15 10:18 ` [PATCH v3 0/4 -mmotm] copy_signal() cleanup Veaceslav Falico
2009-12-15 10:19 ` [PATCH v3 1/4 -mmotm] copy_signal() cleanup: use zalloc and remove initializations Veaceslav Falico
2009-12-15 10:19 ` [PATCH v3 2/4 -mmotm] copy_signal() cleanup: kill taskstats_tgid_init() and acct_init_pacct() Veaceslav Falico
2009-12-15 10:19 ` [PATCH v3 3/4 -mmotm] copy_signal() cleanup: clean thread_group_cputime_init() Veaceslav Falico
2009-12-15 10:20 ` [PATCH v3 4/4 -mmotm] copy_signal() cleanup: clean tty_audit_fork() Veaceslav Falico
2009-12-04 14:29 ` [PATCH v2 2/4] copy_signal cleanup: clean acct_init_pacct() and taskstats_tgid_init() Veaceslav Falico
2009-12-05 16:33 ` Oleg Nesterov
2009-12-07 19:45 ` [PATCH] kill taskstats_tgid_init() and acct_init_pacct() and cleanup copy_signal() Veaceslav Falico
2009-12-07 7:39 ` [PATCH v2 2/4] copy_signal cleanup: clean acct_init_pacct() and taskstats_tgid_init() Balbir Singh
2009-12-04 14:29 ` [PATCH v2 3/4] copy_signal cleanup: clean thread_group_cputime_init() Veaceslav Falico
2009-12-05 16:39 ` Oleg Nesterov
2009-12-04 14:30 ` [PATCH v2 4/4] copy_signal cleanup: clean tty_audit_fork() Veaceslav Falico
2009-12-05 16:58 ` Oleg Nesterov
2009-12-05 20:04 ` Miloslav Trmac
2009-12-06 14:49 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207123615.fc841a83.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=alan@linux.intel.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=gregkh@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.rilling@kerlabs.com \
--cc=mingo@elte.hu \
--cc=mitr@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=renaud.lottiaux@kerlabs.com \
--cc=sgruszka@redhat.com \
--cc=vfalico@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.