From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix debug output.
Date: Mon, 07 Dec 2009 21:09:34 +0100 [thread overview]
Message-ID: <20091207200934.2CDC03F6CC@gemini.denx.de> (raw)
In-Reply-To: <4B1CFEF3.7080302@corscience.de>
Dear Thomas Weber,
In message <4B1CFEF3.7080302@corscience.de> you wrote:
>
> > Which problem is this supposed to fix?
...
> In commit 60f61e6d7655400bb785a2ef637581679941f6d1 the following calls
> where changed.
>
> - DM9000_DMP_PACKET("eth_send", packet, length);
> + DM9000_DMP_PACKET(__func__ , packet, length);
>
> - DM9000_DMP_PACKET("eth_rx", rdptr, RxLen);
> + DM9000_DMP_PACKET(__func__ , rdptr, RxLen);
>
> The identifier __func__ is used to call this macro. Formerly it was a
> string "eth_send" for the function name.
>
> printf("eth_send" ":length ...") worked, but printf(__func__ ":length
> ...") doesn't compile. (tested with gcc-4.4.1)
Well, and exactly this is valuable information which should be
included into the commit message.
Indeed, neither __func__ nor __FUNCTION__ can be concatenated; for
some reason gcc seems to consider these as strings, but not as string
constants. Dunno why; probably there is a good reason for this, but
it looks stupid to me.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Not one hundred percent efficient, of course ... but nothing ever is.
-- Kirk, "Metamorphosis", stardate 3219.8
next prev parent reply other threads:[~2009-12-07 20:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 9:21 [U-Boot] [PATCH] Fix debug output Thomas Weber
2009-12-07 10:43 ` Mike Frysinger
2009-12-07 11:27 ` Thomas Weber
2009-12-07 12:08 ` Wolfgang Denk
2009-12-07 12:07 ` Wolfgang Denk
2009-12-07 13:11 ` Thomas Weber
2009-12-07 20:09 ` Wolfgang Denk [this message]
2009-12-08 20:38 ` Thomas Weber
2009-12-08 20:43 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207200934.2CDC03F6CC@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.