From: Mike Snitzer <snitzer@redhat.com>
To: dm-devel@redhat.com
Cc: Mikulas Patocka <mpatocka@redhat.com>
Subject: [PATCH v5 03/13] dm exception store: snapshot-merge usage accounting
Date: Mon, 7 Dec 2009 16:10:53 -0500 [thread overview]
Message-ID: <20091207211053.GE16769@redhat.com> (raw)
In-Reply-To: <1259893434-10792-4-git-send-email-snitzer@redhat.com>
From: Mike Snitzer <snitzer@redhat.com>
Subject: dm exception store: snapshot-merge usage accounting
Adjust the persistent exception store's next_free to the last chunk that
was processed in persistent_commit_merge(). prepare_merge() may change
ps->current_area but not before commit_merge() processes 'nr_merged'
chunks from it.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>
---
NOTE: this is a replacement for the following patch:
http://patchwork.kernel.org/patch/64746/
---
drivers/md/dm-snap-persistent.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
Index: linux-2.6/drivers/md/dm-snap-persistent.c
===================================================================
--- linux-2.6.orig/drivers/md/dm-snap-persistent.c
+++ linux-2.6/drivers/md/dm-snap-persistent.c
@@ -753,10 +753,14 @@ static int persistent_commit_merge(struc
ps->current_committed -= nr_merged;
/*
- * Note that we make no attempt to keep ps->next_free up-to-date
- * as exceptions may have been allocated out-of-order.
- * Once a snapshot has become merging, nothing further uses it.
+ * Update ps->next_free so persistent_usage() is accurate
+ * - must account for the first two metadata chunks
+ * - prepare_merge() may change ps->current_area but not before
+ * commit_merge() processes 'nr_merged' from the current_area
*/
+ ps->next_free =
+ (area_location(ps, ps->current_area) - 1 +
+ ps->current_committed + 2);
return 0;
}
next prev parent reply other threads:[~2009-12-07 21:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 2:23 [PATCH v5 00/13] snapshot-merge target Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 01/13] dm snapshot: rework writing to snapshot origin Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 02/13] dm exception store: add snapshot-merge specific methods Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 03/13] dm exception store: snapshot-merge usage accounting Mike Snitzer
2009-12-07 21:10 ` Mike Snitzer [this message]
2009-12-07 23:44 ` Alasdair G Kergon
2009-12-07 23:53 ` Mike Snitzer
2009-12-08 0:00 ` Alasdair G Kergon
2009-12-08 2:46 ` Mikulas Patocka
2009-12-04 2:23 ` [PATCH v5 04/13] dm snapshot: add snapshot-merge target Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 05/13] dm snapshot: merge target should not allocate new exceptions Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 06/13] dm snapshot: do not allow more than one merging snapshot Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 07/13] dm snapshot: the merge procedure Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 08/13] dm snapshot: queue writes to an area that is actively being merged Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 09/13] dm snapshot: do not merge a chunk until active writes to it finish Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 10/13] dm snapshot: make exceptions in other snapshots when merging Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 11/13] dm snapshot: redirect accesses to origin if merging snap invalidated Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 12/13] dm snapshot: merge a linear region of chunks using one large IO Mike Snitzer
2009-12-04 2:23 ` [PATCH v5 13/13] dm snapshot: report merge failure in status Mike Snitzer
2009-12-05 18:44 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091207211053.GE16769@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.