All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin Watson <cjwatson@ubuntu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: autogen.sh warnings
Date: Mon, 7 Dec 2009 23:54:56 +0000	[thread overview]
Message-ID: <20091207235455.GL6439@riva.ucam.org> (raw)
In-Reply-To: <4B1D8664.4070403@gmail.com>

On Mon, Dec 07, 2009 at 04:49:08PM -0600, Bruce Dubbs wrote:
> I've been looking at autogen.sh some more.
>
> Does anyone know why the lines:
>
> # FIXME: automake doesn't like that there's no Makefile.am
> automake -a -c -f || true
>
> are present at all?  Since there is no Makefile.am, it looks like  
> automake only creates a few files and aborts.
>
> Doing an experiment, I checked out a new version of trunk twice.  In  
> both cases I ran md5sum on all the files in the top level directory.  In  
> case 1, I didn't change anything and ran autogen.sh and then ran md5sum
> again.  In case 2, I commented out the automake line above.
>
> As you can see below, automake only adds standard 'config.guess',  
> 'config.sub', and 'missing' scripts.
>
> The real purpose of automake is to create a Makefile.in for configure.  
> GRUB doesn't use it for that.  Is there any reason to not just add the  
> three files to the bzr repository and remove the automake line from  
> autogen.sh?

These files do change from time to time, in ways that are important; for
example, config.guess and config.sub are updated to support new
architectures or new variants of existing architectures. It's best to
have this done automatically rather than doing it once manually and then
forgetting about it.

We could have a temporary directory in which we run automake, just for
the purpose of getting hold of these files. Perhaps something like this:

  rm -rf automake-tmp
  mkdir -p automake-tmp
  cat >automake-tmp/configure.ac <<EOF
AC_INIT([temporary], [0.1])
AC_CONFIG_AUX_DIR([.])
AM_INIT_AUTOMAKE
AC_CANONICAL_BUILD
AC_CONFIG_FILES([Makefile])
EOF
  touch automake-tmp/Makefile.am
  (cd automake-tmp && aclocal && automake -a -c -f --foreign)
  cp -a automake-tmp/config.guess automake-tmp/config.sub \
        automake-tmp/install-sh automake-tmp/missing \
        .
  rm -rf automake-tmp

I don't know whether this is worth it, but it would be possible.

-- 
Colin Watson                                       [cjwatson@ubuntu.com]



  reply	other threads:[~2009-12-07 23:55 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-07 17:38 autogen.sh warnings Bruce Dubbs
2009-12-07 19:21 ` Colin Watson
2009-12-07 20:28   ` Bruce Dubbs
2009-12-07 22:12     ` Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-07 23:07       ` Bruce Dubbs
2009-12-07 22:40     ` Colin Watson
2009-12-07 23:26       ` Bruce Dubbs
2009-12-09 21:52   ` Robert Millan
2009-12-09 22:19     ` Bruce Dubbs
2009-12-09 22:34       ` Felix Zielcke
2009-12-09 23:28         ` Bruce Dubbs
2009-12-10  0:25           ` Felix Zielcke
2009-12-10  6:05             ` Bruce Dubbs
2009-12-10 10:15               ` Felix Zielcke
2009-12-10 16:20                 ` Bruce Dubbs
2009-12-24 21:13                   ` Robert Millan
2009-12-29  3:50                     ` Bruce Dubbs
2010-01-01 11:33                       ` Robert Millan
2010-01-01 16:57                         ` Bruce Dubbs
2010-01-03 16:25                           ` Robert Millan
2009-12-10  0:49           ` Robert Millan
2009-12-09 22:56       ` Robert Millan
2009-12-07 19:50 ` Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-07 20:51   ` Bruce Dubbs
2009-12-07 22:16     ` Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-07 22:49     ` Bruce Dubbs
2009-12-07 23:54       ` Colin Watson [this message]
2009-12-08  0:01         ` Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-08  0:13           ` Bruce Dubbs
2010-01-07 19:14             ` Robert Millan
2009-12-08  0:16           ` Colin Watson
2009-12-08  0:34             ` Building system (Re: autogen.sh warnings) Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-08  3:40               ` Bruce Dubbs
2009-12-08 10:20         ` autogen.sh warnings Felix Zielcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091207235455.GL6439@riva.ucam.org \
    --to=cjwatson@ubuntu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.