From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NHnUA-0007MA-Kp for mharc-grub-devel@gnu.org; Mon, 07 Dec 2009 18:59:22 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHnU9-0007Lo-H3 for grub-devel@gnu.org; Mon, 07 Dec 2009 18:59:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHnU4-0007Jh-LE for grub-devel@gnu.org; Mon, 07 Dec 2009 18:59:20 -0500 Received: from [199.232.76.173] (port=56254 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHnU4-0007Je-Eo for grub-devel@gnu.org; Mon, 07 Dec 2009 18:59:16 -0500 Received: from smarthost03.mail.zen.net.uk ([212.23.3.142]:57406) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHnU4-0006LH-Bz for grub-devel@gnu.org; Mon, 07 Dec 2009 18:59:16 -0500 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost03.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1NHnU3-0007lH-FH for grub-devel@gnu.org; Mon, 07 Dec 2009 23:59:15 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1NHnU3-00038C-00; Mon, 07 Dec 2009 23:59:15 +0000 Date: Mon, 7 Dec 2009 23:59:15 +0000 From: Colin Watson To: The development of GNU GRUB Message-ID: <20091207235915.GO6439@riva.ucam.org> References: <20091207140923.GA6439@riva.ucam.org> <20091207201408.GA27276@pina.cat> <20091207205420.GI6439@riva.ucam.org> <20091207224630.GA31855@pina.cat> <20091207233804.GA14236@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091207233804.GA14236@pina.cat> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost03-IP: [82.69.40.219] X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Build failures on Ubuntu due to gettext X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2009 23:59:21 -0000 On Mon, Dec 07, 2009 at 11:38:04PM +0000, Carles Pina i Estany wrote: > On Dec/07/2009, Carles Pina i Estany wrote: > > So I would apply your patch, after understanding that it's only for > > one more thing Colin. What do you think to not apply your patch and > apply the attached patch? > > It force that the argument 1 of _ and N_ is a c-format (in this way > appears in grub.pot). This is, IMO, correct approach. And then msgfmt -c > checks the number of arguments. I really think that this is incorrect, I'm afraid. I've certainly never seen any other project do this. There's no reason to restrict _ and N_ only to be used by printf-a-likes. Cheers, -- Colin Watson [cjwatson@ubuntu.com]