From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NHnfH-0000Op-Le for mharc-grub-devel@gnu.org; Mon, 07 Dec 2009 19:10:51 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHnfF-0000K4-6m for grub-devel@gnu.org; Mon, 07 Dec 2009 19:10:49 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHnfA-00009B-7q for grub-devel@gnu.org; Mon, 07 Dec 2009 19:10:48 -0500 Received: from [199.232.76.173] (port=48615 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHnf9-00008z-VL for grub-devel@gnu.org; Mon, 07 Dec 2009 19:10:44 -0500 Received: from smarthost02.mail.zen.net.uk ([212.23.3.141]:45799) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHnf9-0007n3-Uo for grub-devel@gnu.org; Mon, 07 Dec 2009 19:10:44 -0500 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost02.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1NHnf6-0006e1-UB for grub-devel@gnu.org; Tue, 08 Dec 2009 00:10:43 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1NHnf0-0003EV-00; Tue, 08 Dec 2009 00:10:34 +0000 Date: Tue, 8 Dec 2009 00:10:34 +0000 From: Colin Watson To: The development of GNU GRUB Message-ID: <20091208001033.GQ6439@riva.ucam.org> References: <20091207140923.GA6439@riva.ucam.org> <4B1D7C04.1000503@gmail.com> <20091207231203.GK6439@riva.ucam.org> <20091207233836.GA10791@riva.ucam.org> <4B1D96E0.1020004@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4B1D96E0.1020004@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost02-IP: [82.69.40.219] X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Build failures on Ubuntu due to gettext X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2009 00:10:49 -0000 On Tue, Dec 08, 2009 at 12:59:28AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Colin Watson wrote: > > Furthermore, the style I suggested is used in many other GNU projects. > > Here are just a few examples: > > > > coreutils/src/du.c:994: error (0, 0, "%s", _("invalid zero-length file name")); > > diffutils/src/sdiff.c:853: fprintf (stderr, "%s", _("\ > > diffutils/src/sdiff.c-854-ed:\tEdit then use both versions, each decorated with a header.\n\ > > glibc/inet/rcmd.c:178: __fxprintf(NULL, "%s", _("\ > > glibc/inet/rcmd.c-179-rcmd: socket: All ports in use\n")); > > gnulib/lib/xalloc-die.c:34: error (exit_failure, 0, "%s", _("memory exhausted")); > > I have nothing against defining grub_putl_ (str); equivalent to > grub_printf ("%s\n", str); (defined as function if it's used extensively > for space reasons). > Just from your previous mails it seemed that you proposed to transform > strings like > grub_printf (_("Moving file %s to %s."), f1, f2); to grub_printf ("%s %s > %s %s.", _("Moving file"), f1, _("to"), f2); > to avoid translating format-strings which would be completely > untranslatable. What on earth?! I said nothing of the kind! That would obviously be completely insane. How did you arrive at that impression? My patch made the following transformation: - grub_printf (_("literal string")); + grub_printf ("%s", _("literal string")); This was only necessary in five places, so I doubt that a function is worth it. Thanks, -- Colin Watson [cjwatson@ubuntu.com]