All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
	linux-mm@kvack.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [cleanup][PATCH mmotm]memcg: don't call mem_cgroup_soft_limit_check() against root cgroup (Re: [BUG?] [PATCH] soft limits and root cgroups)
Date: Tue, 8 Dec 2009 07:17:13 +0530	[thread overview]
Message-ID: <20091208014713.GL5780@balbir.in.ibm.com> (raw)
In-Reply-To: <20091208100954.44996a7e.nishimura@mxp.nes.nec.co.jp>

* nishimura@mxp.nes.nec.co.jp <nishimura@mxp.nes.nec.co.jp> [2009-12-08 10:09:54]:

> hi,
> 
> On Mon, 7 Dec 2009 20:41:16 +0200, "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> > Currently, mem_cgroup_update_tree() on root cgroup calls only on
> > uncharge, not on charge.
> > 
> > Is it a bug or not?
> > 
> > Patch to fix, if it's a bug:
> > 
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index 8aa6026..6babef1 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -1366,13 +1366,15 @@ static int __mem_cgroup_try_charge(struct mm_struct *mm
> >                         goto nomem;
> >                 }
> >         }
> > +
> > +done:
> >         /*
> >          * Insert ancestor (and ancestor's ancestors), to softlimit RB-tree.
> >          * if they exceeds softlimit.
> >          */
> >         if (mem_cgroup_soft_limit_check(mem))
> >                 mem_cgroup_update_tree(mem, page);
> > -done:
> > +
> >         return 0;
> >  nomem:
> >         css_put(&mem->css);
> > 
> I think it's not a bug, because softlimit doesn't work for root cgroup.
> (IIUC, it's not disabled to write to <root cgroup>/memory.soft_limit_in_bytes, but
> it has no use because root cgroup doesn't use res_counter.)
> 
> So, I think not to call mem_cgroup_soft_limit_check()(and mem_cgroup_update_tree)
> against root cgroup on uncharge path would be a right fix.
> 
> 
> How about this ?
> ===
> From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> 
> current memory cgroup doesn't use res_counter about root cgroup, so soft limits
> on root cgroup has no use.
> This patch disables writing to <root cgroup>/memory.soft_limit_in_bytes and
> changes uncharge path not to call mem_cgroup_soft_limit_check() against root
> cgroup.
> 
> Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> ---
>  Documentation/cgroups/memory.txt |    1 +
>  mm/memcontrol.c                  |    6 +++++-
>  2 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/cgroups/memory.txt b/Documentation/cgroups/memory.txt
> index b871f25..e1b5328 100644
> --- a/Documentation/cgroups/memory.txt
> +++ b/Documentation/cgroups/memory.txt
> @@ -413,6 +413,7 @@ NOTE1: Soft limits take effect over a long period of time, since they involve
>         reclaiming memory for balancing between memory cgroups
>  NOTE2: It is recommended to set the soft limit always below the hard limit,
>         otherwise the hard limit will take precedence.
> +NOTE3: We cannot set soft limits on the root cgroup any more.
> 
>  8. TODO
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 661b8c6..0751533 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -2056,7 +2056,7 @@ __mem_cgroup_uncharge_common(struct page *page, enum charge_type ctype)
>  	mz = page_cgroup_zoneinfo(pc);
>  	unlock_page_cgroup(pc);
> 
> -	if (mem_cgroup_soft_limit_check(mem))
> +	if (!mem_cgroup_is_root(mem) && mem_cgroup_soft_limit_check(mem))
>  		mem_cgroup_update_tree(mem, page);

May be the mem_cgroup_is_root() check should go inside
mem_cgroup_soft_limit_check() for future call sites as well.

>  	/* at swapout, this memcg will be accessed to record to swap */
>  	if (ctype != MEM_CGROUP_CHARGE_TYPE_SWAPOUT)
> @@ -2787,6 +2787,10 @@ static int mem_cgroup_write(struct cgroup *cont, struct cftype *cft,
>  			ret = mem_cgroup_resize_memsw_limit(memcg, val);
>  		break;
>  	case RES_SOFT_LIMIT:
> +		if (mem_cgroup_is_root(memcg)) { /* Can't set limit on root */
> +			ret = -EINVAL;
> +			break;
> +		}
>  		ret = res_counter_memparse_write_strategy(buffer, &val);
>  		if (ret)
>  			break;
> 

looks good to me

Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
 

-- 
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-12-08  1:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-07 18:41 [BUG?] [PATCH] soft limits and root cgroups Kirill A. Shutemov
2009-12-08  1:09 ` [cleanup][PATCH mmotm]memcg: don't call mem_cgroup_soft_limit_check() against root cgroup (Re: [BUG?] [PATCH] soft limits and root cgroups) Daisuke Nishimura
2009-12-08  1:47   ` Balbir Singh [this message]
2009-12-08  2:13     ` Daisuke Nishimura
2009-12-09  0:24   ` KAMEZAWA Hiroyuki
2009-12-09  9:37 ` [BUG?] [PATCH] soft limits and root cgroups Kirill A. Shutemov
2009-12-09 11:30   ` Daisuke Nishimura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091208014713.GL5780@balbir.in.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kirill@shutemov.name \
    --cc=linux-mm@kvack.org \
    --cc=nishimura@mxp.nes.nec.co.jp \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.