From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pete Zaitcev <zaitcev@redhat.com>
Subject: Re: [PATCH 4/6] cld: modify server code to use logging macros
Date: Tue, 8 Dec 2009 11:13:39 -0700
Message-ID: <20091208111339.5c12115d@redhat.com>
References: <1260232984-26726-1-git-send-email-cmccabe@alumni.cmu.edu>
	<1260232984-26726-2-git-send-email-cmccabe@alumni.cmu.edu>
	<1260232984-26726-3-git-send-email-cmccabe@alumni.cmu.edu>
	<1260232984-26726-4-git-send-email-cmccabe@alumni.cmu.edu>
	<1260232984-26726-5-git-send-email-cmccabe@alumni.cmu.edu>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
In-Reply-To: <1260232984-26726-5-git-send-email-cmccabe@alumni.cmu.edu>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Colin McCabe <cmccabe@alumni.cmu.edu>
Cc: Project Hail List <hail-devel@vger.kernel.org>, Jeff Garzik <jeff@garzik.org>, Colin McCabe <cmccabe@cobalt.club.cc.cmu.edu>, Colin McCabe <cmccabe@alumni.cmu.edu>

On Mon,  7 Dec 2009 16:43:02 -0800
Colin McCabe <cmccabe@alumni.cmu.edu> wrote:

> +++ b/server/cld.h
> @@ -26,6 +26,7 @@
>  #include <glib.h>
>  #include "cldb.h"
>  #include <cld_msg.h>
> +#include "common.h"
>  #include <libtimer.h>

This should be <common.h> since it's common (in include).

> -extern int debugging;
> +extern struct cld_log srv_log;

> -	applog(LOG_INFO, "databases down");
> +	CLD_INFO(&srv_log, "databases down");

Great, you took code that was common across Hail and made it specific
to CLD again.

-- Pete