From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Bob Copeland <me@bobcopeland.com>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
Shahar Or <mightyiampresence@gmail.com>
Subject: Re: [ath5k-devel] [PATCH] ath5k: add support for Dell Vostro A860 LED
Date: Tue, 8 Dec 2009 11:06:59 -0500 [thread overview]
Message-ID: <20091208160659.GG15172@tuxdriver.com> (raw)
In-Reply-To: <43e72e890912080801s52607743s738ed6cdad7d154e@mail.gmail.com>
On Tue, Dec 08, 2009 at 08:01:52AM -0800, Luis R. Rodriguez wrote:
> On Tue, Dec 8, 2009 at 6:57 AM, Bob Copeland <me@bobcopeland.com> wrote:
> > On Mon, Dec 7, 2009 at 4:59 PM, John W. Linville <linville@tuxdriver.com> wrote:
> >> On Mon, Dec 07, 2009 at 12:05:54PM +0200, Shahar Or wrote:
> >>> Adds support for the WiFi activity LED on the Dell Vostro A860 laptop.
> >>>
> >>> Signed-off-by: Shahar Or <shahar@shahar-or.co.il>
> >>> ---
> >>> I hope this one is perfect.
> >
> > Thanks for the patch. As for getting a better solution to LEDs, I
> > trolled through the ACPI spec and code, and while various modules
> > do set up LED pins, there doesn't seem to be a way to generally
> > get that information from another module and it appears different
> > between each vendor. I am by no stretch expert in ACPI stuff
> > though.
> >
> > Luis, I've asked this before but maybe you know better now or know
> > whom to ask on your side. Atheros must have a way on Windows to
> > figure out the LED pin/polarity -- do you have any idea? Ath9k
> > uses the SREV but that seems to be insufficient for ath5k judging
> > by all the quirks.
>
> IIRC this is all mapped in the INF file, I thought I had released an
> INF file under the ISC license but it seems that's not the case, I can
> try to do that if it helps. Anyway, if we can move this sort of map to
> userspace it'd be neat as you'd just need a userspace file update.
> Only thing is how to do this in a generic way for all wireless drivers
> and if this is indeed useful for other drivers.
Export something through sysfs and use a udev rule?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2009-12-08 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 13:07 [PATCH] ath5k: add support for Dell Vostro A860 LED Shahar Or
2009-12-04 19:23 ` John W. Linville
2009-12-07 10:05 ` Shahar Or
2009-12-07 21:59 ` John W. Linville
2009-12-08 14:57 ` [ath5k-devel] " Bob Copeland
2009-12-08 16:01 ` Luis R. Rodriguez
2009-12-08 16:06 ` John W. Linville [this message]
2009-12-08 16:30 ` Luis R. Rodriguez
2009-12-18 11:42 ` Shahar Or
2009-12-18 15:37 ` Luis R. Rodriguez
2009-12-18 16:23 ` Luis R. Rodriguez
2009-12-18 17:03 ` Shahar Or
2009-12-18 17:19 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091208160659.GG15172@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mightyiampresence@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.