From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: u.kleine-koenig@pengutronix.de, daniel@caiaq.de,
dbrownell@users.sourceforge.net, grant.likely@secretlab.ca,
s.hauer@pengutronix.de
Subject: + spi-imx-correct-check-for-platform_get_irq-failing.patch added to -mm tree
Date: Tue, 08 Dec 2009 15:30:04 -0800 [thread overview]
Message-ID: <200912082330.nB8NU4IO016215@imap1.linux-foundation.org> (raw)
The patch titled
spi-imx: correct check for platform_get_irq failing
has been added to the -mm tree. Its filename is
spi-imx-correct-check-for-platform_get_irq-failing.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: spi-imx: correct check for platform_get_irq failing
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
platform_get_irq() returns -ENXIO if there is no entry. So don't check
return value being nonzero but greater or equal to zero.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Daniel Mack <daniel@caiaq.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/spi/spi_imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/spi/spi_imx.c~spi-imx-correct-check-for-platform_get_irq-failing drivers/spi/spi_imx.c
--- a/drivers/spi/spi_imx.c~spi-imx-correct-check-for-platform_get_irq-failing
+++ a/drivers/spi/spi_imx.c
@@ -554,7 +554,7 @@ static int __init spi_imx_probe(struct p
}
spi_imx->irq = platform_get_irq(pdev, 0);
- if (!spi_imx->irq) {
+ if (spi_imx->irq < 0) {
ret = -EINVAL;
goto out_iounmap;
}
_
Patches currently in -mm which might be from u.kleine-koenig@pengutronix.de are
origin.patch
linux-next.patch
sysfs-deprecated-features-are-to-help-old-tools-not-to-confuse-them.patch
hrtimer-correct-a-few-numbers-in-comments.patch
clockevents-ensure-taht-min_delta_ns-is-increased-in-error-path.patch
mxcmmc-fix-error-path-in-mxcmci_probe.patch
spi-drain-mxc-spi-transfer-buffer-when-probing-device.patch
spi-imx-use-platform_driver_probe-as-probe-lives-in-inittext.patch
spi-imx-correct-check-for-platform_get_irq-failing.patch
spi-imx-use-positive-logic-to-distinguish-cpu-variants.patch
spi-imx-add-mx25-support.patch
spi-imx-dont-access-struct-device-directly-but-use-dev_get_platdata.patch
rtc-add-freescale-mc13783-rtc-driver.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2009-12-08 23:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 23:30 akpm [this message]
[not found] ` <fa686aa40912081638m734e97c3r2c3f412898d293b@mail.gmail.com>
[not found] ` <20091209074533.GB8136@pengutronix.de>
[not found] ` <20091209074533.GB8136-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-12-09 15:08 ` + spi-imx-correct-check-for-platform_get_irq-failing.patch added to -mm tree Grant Likely
[not found] ` <fa686aa40912090708g45879802l6cea7b401b1434e3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-12-09 15:32 ` Uwe Kleine-König
[not found] ` <20091209153241.GB1389-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2009-12-09 17:23 ` Grant Likely
2009-12-09 17:55 ` Uwe Kleine-König
2009-12-09 18:00 ` Grant Likely
2009-12-09 18:00 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912082330.nB8NU4IO016215@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=daniel@caiaq.de \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.