From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] Update Makefile for new dirs to be included in tag list
Date: Wed, 9 Dec 2009 05:28:33 -0500 [thread overview]
Message-ID: <200912090528.34552.vapier@gentoo.org> (raw)
In-Reply-To: <1260339968-28169-1-git-send-email-leoli@freescale.com>
On Wednesday 09 December 2009 01:26:06 Li Yang wrote:
> diff --git a/Makefile b/Makefile
> index bcb3fe9..4d71366 100644
> --- a/Makefile
> +++ b/Makefile
> +TAG_SUBDIRS += $(shell if [ -d board/$(VENDOR)/common ]; then echo \
> + "board/$(VENDOR)/common"; fi)
ugh, dont do that. using $(shell) is awful. if you need to do things based
on a dynamic path, use:
ifneq ($(wildcard some/path),)
...
endif
perhaps even better would be to let each dir define a tags.in or something and
have the toplevel Makefile source that
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091209/6bf01346/attachment.pgp
next prev parent reply other threads:[~2009-12-09 10:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 6:26 [U-Boot] [PATCH 1/3] Update Makefile for new dirs to be included in tag list Li Yang
2009-12-09 6:26 ` [U-Boot] [PATCH 2/3] fdt: add fdt_del_node_by_path() API Li Yang
2009-12-09 6:26 ` [U-Boot] [PATCH 3/3] fsl_law: add SRIO2 target id and law_size_bits() macro Li Yang
2009-12-10 19:49 ` Kumar Gala
2009-12-10 2:48 ` [U-Boot] [PATCH 2/3] fdt: add fdt_del_node_by_path() API Jerry Van Baren
2009-12-10 4:12 ` Li Yang-R58472
2009-12-10 6:37 ` Wolfgang Denk
2009-12-10 6:49 ` Li Yang-R58472
2009-12-09 9:12 ` [U-Boot] [PATCH 1/3] Update Makefile for new dirs to be included in tag list Wolfgang Denk
2009-12-09 9:47 ` Li Yang-R58472
2009-12-09 10:28 ` Mike Frysinger [this message]
2009-12-09 10:29 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912090528.34552.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.