From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Wed, 9 Dec 2009 05:29:38 -0500
Subject: [U-Boot] [PATCH 1/3] Update Makefile for new dirs to be
	included in tag list
In-Reply-To: <200912090528.34552.vapier@gentoo.org>
References: <1260339968-28169-1-git-send-email-leoli@freescale.com>
	<200912090528.34552.vapier@gentoo.org>
Message-ID: <200912090529.39528.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday 09 December 2009 05:28:33 Mike Frysinger wrote:
> On Wednesday 09 December 2009 01:26:06 Li Yang wrote:
> > diff --git a/Makefile b/Makefile
> > index bcb3fe9..4d71366 100644
> > --- a/Makefile
> > +++ b/Makefile
> > +TAG_SUBDIRS += $(shell if [ -d board/$(VENDOR)/common ]; then echo \
> > +	"board/$(VENDOR)/common"; fi)
> 
> ugh, dont do that.  using $(shell) is awful.  if you need to do things
>  based on a  dynamic path, use:
> ifneq ($(wildcard some/path),)
> ...
> endif
> 
> perhaps even better would be to let each dir define a tags.in or something
>  and have the toplevel Makefile source that

nm, Wolfgang proposed a better idea already
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091209/94876c8f/attachment.pgp