From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <peterz@infradead.org>
Subject: [patch 3/4] sched: Rename bogus label in sched_setaffinity()
Date: Wed, 09 Dec 2009 10:15:06 -0000 [thread overview]
Message-ID: <20091209100706.827251164@linutronix.de> (raw)
In-Reply-To: 20091209100540.511353305@linutronix.de
[-- Attachment #1: sched-fix-bogus-label.patch --]
[-- Type: text/plain, Size: 952 bytes --]
out_unlock: is bogus as there is nothing to unlock. Rename it.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/sched.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: linux-2.6-tip/kernel/sched.c
===================================================================
--- linux-2.6-tip.orig/kernel/sched.c
+++ linux-2.6-tip/kernel/sched.c
@@ -6558,11 +6558,11 @@ long sched_setaffinity(pid_t pid, const
}
retval = -EPERM;
if (!check_same_owner(p) && !capable(CAP_SYS_NICE))
- goto out_unlock;
+ goto out_free;
retval = security_task_setscheduler(p, 0, NULL);
if (retval)
- goto out_unlock;
+ goto out_free;
cpuset_cpus_allowed(p, cpus_allowed);
cpumask_and(new_mask, in_mask, cpus_allowed);
@@ -6581,7 +6581,7 @@ long sched_setaffinity(pid_t pid, const
goto again;
}
}
-out_unlock:
+out_free:
free_cpumask_var(new_mask);
out_free_cpus_allowed:
free_cpumask_var(cpus_allowed);
next prev parent reply other threads:[~2009-12-09 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 10:14 [patch 0/4] sched: Replace read_lock(&tasklist_lock) with RCU - the easy part Thomas Gleixner
2009-12-09 10:14 ` [patch 1/4] sched: Use rcu in sys_sched_getscheduler/sys_sched_getparam() Thomas Gleixner
2009-12-14 16:31 ` [tip:sched/urgent] " tip-bot for Thomas Gleixner
2009-12-09 10:15 ` [patch 2/4] sched: Use rcu in sched_get/set_affinity() Thomas Gleixner
2009-12-14 16:31 ` [tip:sched/urgent] " tip-bot for Thomas Gleixner
2009-12-09 10:15 ` Thomas Gleixner [this message]
2009-12-09 10:15 ` [patch 4/4] sched: Use rcu in sched_get_rr_param Thomas Gleixner
2009-12-14 16:31 ` [tip:sched/urgent] sched: Use rcu in sched_get_rr_param() tip-bot for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091209100706.827251164@linutronix.de \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.