Re: [PATCH 2/2] ASoC: Add FSI-DA7210 sound support for SuperH

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Wed, Dec 09, 2009 at 11:53:37AM +0900, Kuninori Morimoto wrote:

> +static int fsi_da7210_init(struct snd_soc_codec *codec)
> +{
> +	return snd_soc_dai_set_fmt(&da7210_dai,
> +				   SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
> +				   SND_SOC_DAIFMT_CBM_CFM);
> +
> +	/* Use this function to add machine dapm controls */
> +	return 0;
> +}

The second return statement can be removed - I suspect some compiler
versions will warn about unreachable code there.

> +#define DA7210_BUS 0
> +#define DA7210_ADR (0x34 >> 1)
> +static int da7210_add_i2c_device(void)
> +{

This should be being done by the arch code rather than here, and there's
no code to remove the device on shutdown.  This idiom has been used by
some drivers as part of a transition from the old style ASoC stuff where
the I2C device was registered in the CODEC to reduce cross tree issues
but it's best to avoid it for new code.