From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pete Zaitcev Subject: Re: [PATCH 5/6] cld: modify cld-dns to use logging macros Date: Wed, 9 Dec 2009 13:35:05 -0700 Message-ID: <20091209133505.18b6a2b0@redhat.com> References: <1260317516-30991-1-git-send-email-cmccabe@alumni.cmu.edu> <1260317516-30991-6-git-send-email-cmccabe@alumni.cmu.edu> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1260317516-30991-6-git-send-email-cmccabe@alumni.cmu.edu> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Colin McCabe Cc: Project Hail List , Jeff Garzik , Colin McCabe On Tue, 8 Dec 2009 16:11:55 -0800 Colin McCabe wrote: > @@ -161,8 +153,8 @@ static void push_host(GList **host_list, struct cldc_host *hp_in) > * This is not reentrant. Better be called before any other threads > * are started. > */ > -int cldc_getaddr(GList **host_list, const char *thishost, bool verbose, > - void (*act_log)(int prio, const char *fmt, ...)) > +int cldc_getaddr(GList **host_list, const char *thishost, > + struct hail_log *log) > { Nothing about the change as such, but you are going to change users of these public interfaces too, right? I mean Chunk and tabled. -- Pete