From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: Re: [PATCH 2] HVM vcpu add/remove: setup dsdt and madt infrastructure for vcpu add/remove Date: Wed, 9 Dec 2009 14:52:49 +0100 Message-ID: <200912091452.49768.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: "Liu, Jinsong" , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Wednesday 09 December 2009 13:21:17 Keir Fraser wrote: > On 09/12/2009 12:04, "Keir Fraser" wrote: > >> What's the MADT checksum stuff in the DSDT all about? Does the MADT > >> really have to stay consistent and checksummed after boot - I would have > >> assumed that it provides a boot-time snapshot of the system only, and > >> would not be looked at by the OSPM after boot. I haven't looked at the > >> ASL code in detail but I'll surely bet that the approach is fragile. > > > > Ah, this has to do with the _MAT methods doesn't it. Well, I wonder > > whether the strategy of sharing the _MAT return values and the MADT > > entries is actually sensible. There seems to be no really good reason to > > do it -- they should be consistent at boot-time of course, but after boot > > the MADT isn't expected to remain live and up-to-date I believe? Then > > each Processor object can define its own MAT buffer which it manages > > entirely by and for itself. > > Hmm, well, the ACPI spec's example does have the entries shared I think. > Perhaps it does make sense then, although I'm still unsure whether > maintaining the MADT checksum is required? Tools like acpidump or iasl may verify the checksum. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632