From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 2/3] c/r: kread/kwrite() to abort if CKPT_CTX_ERROR is set Date: Wed, 9 Dec 2009 09:34:07 -0600 Message-ID: <20091209153407.GA12496@us.ibm.com> References: <1260130151-2500-1-git-send-email-orenl@cs.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1260130151-2500-1-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org): > This is useful particularly in restart to force a task that is > restoring to respond quickly to an error condition due to another > task, instead of only detecting it when it completes (or fails). > For example, when a restarting tasks activates the next task, and > then fails. > > Signed-off-by: Oren Laadan Hmm, true, that has obscured a few bugs for me already :) thanks, -serge > --- > checkpoint/sys.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/checkpoint/sys.c b/checkpoint/sys.c > index dbee469..afcfa1e 100644 > --- a/checkpoint/sys.c > +++ b/checkpoint/sys.c > @@ -65,6 +65,9 @@ int ckpt_kwrite(struct ckpt_ctx *ctx, void *addr, int count) > mm_segment_t fs; > int ret; > > + if (ckpt_test_ctx_error(ctx)) > + return ckpt_get_error(ctx); > + > fs = get_fs(); > set_fs(KERNEL_DS); > ret = _ckpt_kwrite(ctx->file, addr, count); > @@ -102,6 +105,9 @@ int ckpt_kread(struct ckpt_ctx *ctx, void *addr, int count) > mm_segment_t fs; > int ret; > > + if (ckpt_test_ctx_error(ctx)) > + return ckpt_get_error(ctx); > + > fs = get_fs(); > set_fs(KERNEL_DS); > ret = _ckpt_kread(ctx->file , addr, count); > -- > 1.6.3.3 > > _______________________________________________ > Containers mailing list > Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > https://lists.linux-foundation.org/mailman/listinfo/containers