From: Arnd Bergmann <arnd@arndb.de>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH, try 2, version 2] qemu/tap: add -net tap, dev= option
Date: Wed, 9 Dec 2009 16:48:20 +0100 [thread overview]
Message-ID: <200912091648.20789.arnd@arndb.de> (raw)
In-Reply-To: <20091209152728.GA4619@redhat.com>
On Wednesday 09 December 2009, Michael S. Tsirkin wrote:
> On Wed, Dec 09, 2009 at 03:49:04PM +0100, Arnd Bergmann wrote:
> >
> > - TFR(fd = open("/dev/net/tun", O_RDWR));
> > + if (!*dev)
> > + dev = "/dev/net/tun";
> > +
>
> Did you test without dev parameter? I think dev will be NULL
> so this will deference a nullpointer ...
> probably if (!dev) is what you mean?
D'oh. will fix.
> will be neater if you put [,dev=str] after [,script=file]
> Also - it does need a string, but only insofar as all options are strings.
> Maybe dev=devfile or dev=file would be clearer.
Yep. Thanks,
Arnd
next prev parent reply other threads:[~2009-12-09 15:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 17:41 [Qemu-devel] [PATCH, try 2] qemu/tap: add -net tap,dev= option Arnd Bergmann
2009-12-09 10:33 ` Mark McLoughlin
2009-12-09 11:53 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-09 12:33 ` Arnd Bergmann
2009-12-09 13:21 ` [Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap, dev= option Christoph Egger
2009-12-09 13:23 ` [Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap,dev= option Michael S. Tsirkin
2009-12-09 14:49 ` [Qemu-devel] [PATCH, try 2, version 2] qemu/tap: add -net tap, dev= option Arnd Bergmann
2009-12-09 15:27 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-09 15:48 ` Arnd Bergmann [this message]
2009-12-09 19:39 ` [Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap,dev= option Anthony Liguori
2009-12-10 8:55 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912091648.20789.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.