Re: [PATCH 1/3] [RFC] vfs: add generic reserved space management interface

[Matthew Wilcox <matthew@wil.cx>]

On Wed, Dec 09, 2009 at 05:51:17PM +0300, Dmitry Monakhov wrote:
> >From other point of view, we may change inode structure like this:
> struct quota_ptr
> {
>         struct dquot            *dquot[MAXQUOTAS];
> };
> struct quota_rsv_ptr
> {
>         struct dquot            *dquot[MAXQUOTAS];
>         qsize_t                 reservation;
> };
> struct inode {
> ....
> #ifdef CONFIG_QUOTA
>        union {
>              struct quota_ptr i_dquot;
>              struct quota_rsv_ptr i_dquot_rsv;
>        };
> #endif
> ....
> };

What's wrong with:

#ifdef CONFIG_QUOTA
	union {
		struct dquot	*i_dquot[MAXQUOTAS];
		struct quota_rsv_ptr i_dquot_rsv;
	};
#endif


voila, no changes needed.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."