From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NIXY3-0006JV-KK for mharc-grub-devel@gnu.org; Wed, 09 Dec 2009 20:10:27 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NIXY2-0006Ii-54 for grub-devel@gnu.org; Wed, 09 Dec 2009 20:10:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NIXXx-0006G2-Ls for grub-devel@gnu.org; Wed, 09 Dec 2009 20:10:25 -0500 Received: from [199.232.76.173] (port=40809 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIXXx-0006Fz-J8 for grub-devel@gnu.org; Wed, 09 Dec 2009 20:10:21 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:38221 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NIXXx-0004VR-7f for grub-devel@gnu.org; Wed, 09 Dec 2009 20:10:21 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NIXXv-0003nW-IU for grub-devel@gnu.org; Thu, 10 Dec 2009 02:10:19 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NIXXv-00044j-2Q for grub-devel@gnu.org; Thu, 10 Dec 2009 02:10:19 +0100 Date: Thu, 10 Dec 2009 02:10:19 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20091210011019.GD15546@thorin> References: <20091207140923.GA6439@riva.ucam.org> <4B1D7C04.1000503@gmail.com> <20091207231203.GK6439@riva.ucam.org> <20091207233836.GA10791@riva.ucam.org> <4B1D96E0.1020004@gmail.com> <20091208001033.GQ6439@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091208001033.GQ6439@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Build failures on Ubuntu due to gettext X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2009 01:10:26 -0000 On Tue, Dec 08, 2009 at 12:10:34AM +0000, Colin Watson wrote: > > My patch made the following transformation: > > - grub_printf (_("literal string")); > + grub_printf ("%s", _("literal string")); > > This was only necessary in five places, so I doubt that a function is > worth it. I think we all agree that it's safer to avoid gettextizing the template; furthemore I agree with Colin that this seems to be a correct approach, but our case is unusual in that we're very pressed for size. Even if we're only discussing a change in five places, I assume we're going to find this situation in lots of calls throurough GRUB code. If this is so, it really calls for a solution that doesn't make GCC generate two memory references and pass two arguments. So first of all, how many times are we going to find similar calls that need to be adjusted in some way? If we're going to find many of them (as I expect), I think this warrants adding a new function (which, btw, will also make GRUB slightly faster). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."