All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Memory leak in two error corner cases
Date: Thu, 10 Dec 2009 09:02:40 +0100	[thread overview]
Message-ID: <20091210080240.GE25549@elte.hu> (raw)
In-Reply-To: <1260380746-4856-1-git-send-email-ext-phil.2.carmody@nokia.com>


* Phil Carmody <ext-phil.2.carmody@nokia.com> wrote:

> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -9841,8 +9841,10 @@ int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
>  
>  		se = kzalloc_node(sizeof(struct sched_entity),
>  				  GFP_KERNEL, cpu_to_node(i));
> -		if (!se)
> +		if (!se) {
> +			kfree(cfs_rq);
>  			goto err;
> +		}

would be nice to turn this into a regular pattern of:

		if (!se)
			goto err_kfree;

where err_kfree does the kfree.

Thanks,

	Ingo

  parent reply	other threads:[~2009-12-10  8:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-09 17:45 [PATCH] sched: Memory leak in two error corner cases Phil Carmody
2009-12-09 17:54 ` Peter Zijlstra
2009-12-10  2:39 ` Helight.Xu
2009-12-10  5:12   ` Peter Zijlstra
2009-12-10  8:02 ` Ingo Molnar [this message]
2009-12-10 12:29   ` [PATCH] [v2] " Phil Carmody
2009-12-10 13:37     ` [tip:sched/urgent] sched: Fix memory " tip-bot for Phil Carmody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091210080240.GE25549@elte.hu \
    --to=mingo@elte.hu \
    --cc=ext-phil.2.carmody@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.