From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa/zeus: Allow use of 8250-compatible UART in uncompress
Date: Thu, 10 Dec 2009 16:19:41 +0800 [thread overview]
Message-ID: <20091210081940.GB28539@buzzloop.caiaq.de> (raw)
In-Reply-To: <20091210090949.35ae1a1b@hina.wild-wind.fr.eu.org>
On Thu, Dec 10, 2009 at 09:09:49AM +0100, Marc Zyngier wrote:
> On Thu, 10 Dec 2009 15:12:08 +0800
> Daniel Mack <daniel@caiaq.de> wrote:
>
> > ... with UART being char* now (and as UART_REG is just a macro) it
> > will only be 8 bits in width, and hence all logic that accesses bits
> > beyond that scope wil fail. Tricky casting might help here, but your
> > referencing that as an array, so the value will be &= 0xff.
> > Or did I overlook anything?
>
> Well, all registers are actually 8bit wide. So I feel like using char*
> is actually one step closer to the actual behavior of the hardware.
> Unless I in turn overlooked something else... ;-)
Ah ok, I missed that. Would be good to hve a comment stating that, for
the next one to stumble over it :)
Daniel
prev parent reply other threads:[~2009-12-10 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 6:39 [PATCH] pxa/zeus: Allow use of 8250-compatible UART in uncompress Marc Zyngier
2009-12-10 7:12 ` Daniel Mack
2009-12-10 8:09 ` Marc Zyngier
2009-12-10 8:19 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210081940.GB28539@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.