From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NIn8y-0007Lb-BR
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 12:49:36 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NIn8t-0007IU-Jr
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 12:49:35 -0500
Received: from [199.232.76.173] (port=52668 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NIn8t-0007II-3s
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 12:49:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34192)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <lcapitulino@redhat.com>) id 1NIn8t-00011F-8P
	for qemu-devel@nongnu.org; Thu, 10 Dec 2009 12:49:31 -0500
Date: Thu, 10 Dec 2009 15:49:20 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 10/19] monitor: Convert do_info_name() to
	QObject
Message-ID: <20091210154920.4eba76bb@doriath>
In-Reply-To: <20091210173813.GA23219@redhat.com>
References: <1260376078-8694-11-git-send-email-lcapitulino@redhat.com>
	<m3tyvz5edq.fsf@crossbow.pond.sub.org>
	<20091210095237.38cafe5c@doriath>
	<4B20F003.6070409@linux.vnet.ibm.com> <4B2119F9.6010003@redhat.com>
	<4B211BE2.60907@linux.vnet.ibm.com> <4B211D6F.7020906@redhat.com>
	<4B211FDF.4070509@linux.vnet.ibm.com> <4B2120C6.1020004@redhat.com>
	<20091210145457.25ba1f09@doriath>
	<20091210173813.GA23219@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@linux.vnet.ibm.com>, Avi Kivity <avi@redhat.com>, Markus Armbruster <armbru@redhat.com>

On Thu, 10 Dec 2009 17:38:13 +0000
"Daniel P. Berrange" <berrange@redhat.com> wrote:

> On Thu, Dec 10, 2009 at 02:54:57PM -0200, Luiz Capitulino wrote:

> >  An option we have is: libvirt actually uses four or five of those
> > info commands. So, we could drop all the rest and guarantee that
> > only those libvirt ones are 100% correct.
> 
> Please don't do that.

 I won't.

> libvirt is adding support for new features all the
> time. I don't want to be in the situation where we can't add a new feature
> because it is missing in the JSON impl. If we're going to provide a supported
> JSON monitor it needs to have all the commands converted, otherwise we'll
> have to stick with using the text based monitor.

 But 0.12 won't have all commands converted, this page has a listing
of what we're going to have:

http://www.linux-kvm.org/page/MonitorProtocol#Conversion_work_detailed_status

 'converted' and 'merged' are guaranteed, Markus did some work and enabled
one or two which are not there.

 I know that the usb and net ones are vital for you, I've patches enabling
them but their error handling is very difficult to get right.