From: "Shawn O. Pearce" <spearce@spearce.org>
To: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Cc: git@vger.kernel.org
Subject: Re: [REROLL PATCH v2 6/8] Support remote helpers implementing smart transports
Date: Thu, 10 Dec 2009 07:58:11 -0800 [thread overview]
Message-ID: <20091210155811.GC30665@spearce.org> (raw)
In-Reply-To: <1260372394-16427-7-git-send-email-ilari.liusvaara@elisanet.fi>
Ilari Liusvaara <ilari.liusvaara@elisanet.fi> wrote:
> Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
This is better.
> + if (strcmp(name, exec)) {
> + r = set_helper_option(transport, "servpath", exec);
> + if (r > 0)
> + fprintf(stderr, "Warning: Setting remote service path "
> + "not supported by protocol.\n");
> + else if (r < 0)
> + fprintf(stderr, "Warning: Invalid remote service "
> + "path.\n");
Style-nit: We prefer "warning: " with lowercase.
--
Shawn.
next prev parent reply other threads:[~2009-12-10 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 15:26 [REROLL PATCH v2 0/8] Remote helpers smart transport extensions Ilari Liusvaara
2009-12-09 15:26 ` [REROLL PATCH v2 1/8] Add remote helper debug mode Ilari Liusvaara
2009-12-09 15:26 ` [REROLL PATCH v2 2/8] Support mandatory capabilities Ilari Liusvaara
2009-12-09 15:26 ` [REROLL PATCH v2 3/8] Pass unknown protocols to external protocol handlers Ilari Liusvaara
2009-12-09 15:26 ` [REROLL PATCH v2 4/8] Refactor git transport options parsing Ilari Liusvaara
2009-12-09 15:26 ` [REROLL PATCH v2 5/8] Support taking over transports Ilari Liusvaara
2009-12-09 15:26 ` [REROLL PATCH v2 6/8] Support remote helpers implementing smart transports Ilari Liusvaara
2009-12-10 15:58 ` Shawn O. Pearce [this message]
2009-12-10 17:10 ` Junio C Hamano
2009-12-09 15:26 ` [REROLL PATCH v2 7/8] Support remote archive from all " Ilari Liusvaara
2009-12-09 15:26 ` [REROLL PATCH v2 8/8] Remove special casing of http, https and ftp Ilari Liusvaara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210155811.GC30665@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.