Re: [2.6.32] WARNING: at arch/x86/kernel/apic/apic.c:249 native_apic_write_dummy+0x30/0x3c()

[Cyrill Gorcunov <gorcunov@gmail.com>]

On Thu, Dec 10, 2009 at 05:37:45PM +0100, Ingo Molnar wrote:
...
> >  
> > +	perfmon_check_apic(&x86_pmu);
> > +
> >  	return 0;
> >  }
> 
> Similar check needed in intel_pmu_init() as well?

Yes (though p6 model already has such a check [fixed by Peter iirc])

>
> Also, i'd suggest to 
> name it pmu_check_apic() or so - and why call it in the middle of of the 
> PMU init functions? All PMU drivers are APIC based, so this call can be 
> done right after:
> 
>         if (err != 0) {
>                 pr_cont("no PMU driver, software events only.\n");
>                 return;
>         }
> 
> 	pmu_check_apic();
> 
> in a single place. Also, no need to pass in &x86_pmu - we have a single 
> PMU driver.
> 
> Thanks,
> 
> 	Ingo
> 

OK, will update and resend. Thanks for comments!

	-- Cyrill