From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NIszs-0005S2-3S for mharc-grub-devel@gnu.org; Thu, 10 Dec 2009 19:04:36 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NIszp-0005ON-H4 for grub-devel@gnu.org; Thu, 10 Dec 2009 19:04:33 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NIszk-0005FV-9f for grub-devel@gnu.org; Thu, 10 Dec 2009 19:04:32 -0500 Received: from [199.232.76.173] (port=49871 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIszk-0005FD-3G for grub-devel@gnu.org; Thu, 10 Dec 2009 19:04:28 -0500 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:35029 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NIszj-00041Y-Ct for grub-devel@gnu.org; Thu, 10 Dec 2009 19:04:27 -0500 Received: from pinux (82-45-164-87.cable.ubr06.hari.blueyonder.co.uk [82.45.164.87]) by mail.pina.cat (Postfix) with ESMTP id 25FBA288F2FDA for ; Fri, 11 Dec 2009 01:04:24 +0100 (CET) Received: by pinux (Postfix, from userid 1000) id 5CF9D85CC; Fri, 11 Dec 2009 00:04:38 +0000 (GMT) Date: Fri, 11 Dec 2009 00:04:38 +0000 From: Carles Pina i Estany To: The development of GNU GRUB Message-ID: <20091211000438.GA6244@pina.cat> References: <20091207140923.GA6439@riva.ucam.org> <4B1D7C04.1000503@gmail.com> <20091207231203.GK6439@riva.ucam.org> <20091207233836.GA10791@riva.ucam.org> <4B1D96E0.1020004@gmail.com> <20091208001033.GQ6439@riva.ucam.org> <20091210011019.GD15546@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091210011019.GD15546@thorin> User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Build failures on Ubuntu due to gettext X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Dec 2009 00:04:33 -0000 Hi, On Dec/10/2009, Robert Millan wrote: > On Tue, Dec 08, 2009 at 12:10:34AM +0000, Colin Watson wrote: > Even if we're only discussing a change in five places, I assume we're > going to find this situation in lots of calls throurough GRUB code. > If this is so, it really calls for a solution that doesn't make GCC > generate two memory references and pass two arguments. > > So first of all, how many times are we going to find similar calls > that very rush numbers, based on my non-commited pending to improve patch to change commands/*: carles@pinux:~/grub2/grub/po$ grep -A 3 "\#\: commands\/" grub.pot | grep ^msgid | grep -c -v % 86 > need to be adjusted in some way? If we're going to find many of them > (as I expect), I think this warrants adding a new function (which, > btw, will also make GRUB slightly faster). Plus about 10 in normal/* (aprox, 5 that Colin did and some more in another pending patch I guess) I haven't looked in other code yet. I think that Vladimir proposed to do it in a macro now and then properly count and implement as a function or not later. From: Vladimir Date: Tue, 08 Dec 2009 01:15:30 +0100 > Then it's not worth it. But again we haven't gettext'ized whole grub2 > yet to know for sure. Perhaps a macro so we can change it later if > necessary? So, for about 86 in commands/* and probably some more in normal/*: function now? Now a macro and then we review? Colin: for me you can commit your patch some way or another so you could compile in Ubuntu and I can commit soon more things. Thanks, -- Carles Pina i Estany http://pinux.info