All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Wenji Huang <wenji.huang@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: add checks for printing graph irq
Date: Fri, 11 Dec 2009 18:44:31 +0100	[thread overview]
Message-ID: <20091211174425.GB5094@nowhere> (raw)
In-Reply-To: <1260543650.2146.358.camel@gandalf.stny.rr.com>

On Fri, Dec 11, 2009 at 10:00:50AM -0500, Steven Rostedt wrote:
> On Fri, 2009-12-11 at 12:19 +0100, Frederic Weisbecker wrote:
> > On Fri, Dec 11, 2009 at 05:38:35PM +0800, Wenji Huang wrote:
> > > Check return value of trace_seq_printf.
> > > 
> > > Signed-off-by: Wenji Huang <wenji.huang@oracle.com>
> > > ---
> > 
> > 
> > I'm applying it, I'll send the fix for the problem you've reported
> > at the same time.
> 
> As for my comment to the patch. Please do not apply this.
> 
> Thanks,


Ok. Yeah you're right, the seq buffer will refuse them once
it's fullfilled anyway, so only the last check matters, we have
too much of these checks in the current code.


  reply	other threads:[~2009-12-11 17:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11  9:38 [PATCH] tracing: add checks for printing graph irq Wenji Huang
2009-12-11 11:18 ` Frederic Weisbecker
2009-12-11 11:19 ` Frederic Weisbecker
2009-12-11 15:00   ` Steven Rostedt
2009-12-11 17:44     ` Frederic Weisbecker [this message]
2009-12-11 15:00 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091211174425.GB5094@nowhere \
    --to=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=wenji.huang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.