From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NJCX4-0001Ym-Hj for qemu-devel@nongnu.org; Fri, 11 Dec 2009 15:56:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NJCWz-0001Xu-3j for qemu-devel@nongnu.org; Fri, 11 Dec 2009 15:56:09 -0500 Received: from [199.232.76.173] (port=43523 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NJCWy-0001Xr-Tx for qemu-devel@nongnu.org; Fri, 11 Dec 2009 15:56:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36100) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NJCWy-0004U2-E7 for qemu-devel@nongnu.org; Fri, 11 Dec 2009 15:56:04 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBBKu3bM031327 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 11 Dec 2009 15:56:03 -0500 Received: from file.fab.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBBKu1Dh013708 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 11 Dec 2009 15:56:03 -0500 Received: from file.fab.redhat.com (localhost.localdomain [127.0.0.1]) by file.fab.redhat.com (8.13.1/8.13.1) with ESMTP id nBBKu1ux028827 for ; Fri, 11 Dec 2009 20:56:01 GMT Received: (from berrange@localhost) by file.fab.redhat.com (8.13.1/8.13.1/Submit) id nBBKu1cu028823 for qemu-devel@nongnu.org; Fri, 11 Dec 2009 20:56:01 GMT Date: Fri, 11 Dec 2009 20:56:01 +0000 From: "Daniel P. Berrange" Message-ID: <20091211205601.GK21297@redhat.com> References: <1260564571-28005-1-git-send-email-berrange@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1260564571-28005-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] Re: [PATCH] Avoid permanently disabled QEMU monitor when UNIX migration fails Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Fri, Dec 11, 2009 at 08:49:31PM +0000, Daniel P. Berrange wrote: > If a UNIX migration command is attempt to a UNIX socket which does > not exist, then the monitor is suspended, but never resumed. This > prevents any further use of the monitor > > * migration-unix.c: Only call migrate_fd_monitor_suspend() once > connected to the UNIX socket. Sorry, forgot to include the signed-off tag with this patch, so will resend. FYI, the test case here is simply (qemu) migrate unix:/tmp/doesnotexist migration failed ...now hung, no prompt returns.. There is also similar kind of problem with exec migration, but I have not been able to figure out where the problem lies for that one. I suspect something is not dealing with errors properly in the buffered file code. If someone fancies investigating the exec: issue, the test case is simply to run exec with a command that fails, eg give invalid syntax for one of its args. I discovered the problem when i did a simple typo with dd (qemu) migrate "exec:dd bs-1m of=/tmp/file" dd: unrecognized operand `bs-1m' Try `dd --help' for more information. ...now hung, no prompt returns.. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|