From: Chuck Lever <chuck.lever@oracle.com>
To: neilb@suse.de
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH] libexport.a: fix a long-standing typo in name_cmp()
Date: Fri, 11 Dec 2009 16:27:31 -0500 [thread overview]
Message-ID: <20091211212608.29241.27167.stgit@localhost.localdomain> (raw)
Not sure what "(!*a || !a == ',')" means... but just a few lines later is
"(!*a || *a == ',')". I think "a is '\0' or ','" is what was intended.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
Neil --
Looks like a typo. Comments?
support/export/client.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/support/export/client.c b/support/export/client.c
index b08dda2..cb6e659 100644
--- a/support/export/client.c
+++ b/support/export/client.c
@@ -266,7 +266,7 @@ name_cmp(char *a, char *b)
/* compare strings a and b, but only upto ',' in a */
while (*a && *b && *a != ',' && *a == *b)
a++, b++;
- if (!*b && (!*a || !a == ',') )
+ if (!*b && (!*a || *a == ','))
return 0;
if (!*b) return 1;
if (!*a || *a == ',') return -1;
next reply other threads:[~2009-12-11 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 21:27 Chuck Lever [this message]
[not found] ` <20091211212608.29241.27167.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-12-23 19:40 ` [PATCH] libexport.a: fix a long-standing typo in name_cmp() Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091211212608.29241.27167.stgit@localhost.localdomain \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.