From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: Re: [PATCH][cr-tests] Ensure pthread stack attributes are restored Date: Fri, 11 Dec 2009 17:53:51 -0800 Message-ID: <20091212015350.GA11487@us.ibm.com> References: <20091211041126.GC20947@us.ibm.com> <20091211153402.GA28867@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20091211153402.GA28867-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: Containers List-Id: containers.vger.kernel.org Serge E. Hallyn [serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org] wrote: | Quoting Sukadev Bhattiprolu (sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org): | > +++ b/process-tree/run-pthread2.sh | > @@ -0,0 +1,206 @@ | > +#!/bin/bash | > + | > +source ../common.sh | > + | > +#dir=`mktemp -p . -d -t cr_pthread2_XXXXXXX` || (echo "mktemp failed"; exit 1) | > +dir=cr_pthread2 | | Note that this means we won't be able to run multiple instances in | parallel. Why did you need to do this? | Grr, I meant to remove that after my testing. Anyway, I am wondering if I should just extend the test case to memcmp() the pthread_attr_t before and after C/R rather than individually testing each attribute (like the stack addr/size in this case). I am working on an update to this test and will fix this too. Sukadev