Re: package VDR for OE

["Petr Štetiar" <ynezz@true.cz>]

Paul Menzel <paulepanter@users.sourceforge.net> [2009-12-13 14:46:20]:

> Thank you! I tried this
> 
>         +-INCLUDES = -I/usr/include/freetype2
>         ++INCLUDES = -I${STAGING_INCDIR}/freetype2
> 
> but the `${STAGING_INCDIR}` was not expanded. The result is the
> following.
> 
>         INCLUDES = -I${STAGING_INCDIR}freetype2
> 
> Using an absolute path worked.
> 
> Could you please point out my mistake?

Maybe, it's because you don't have STAGING_INCDIR variable available in
do_compile() step. If I were you, I would grep for STAGING_INCDIR variable in
other recipes: grep -R STAGING_INCDIR recipes/* and you should get idea how to
use it. Hint, change :

INCLUDES = -I${STAGING_INCDIR}freetype2

to 

INCLUDES = ${CFLAGS}

and in your recipe do:

CFLAGS_append  += " -I${STAGING_INCDIR}/freetype2"

> Furthermore is there a better way for upstream to set things up so that
> no patching is needed? Or is autotools needed for this?

No for this hardcoded paths.

> +--- vdr/Makefile~fixpaths	2009-10-18 15:59:25.000000000 +0200
> ++++ vdr/Makefile	2009-12-13 12:28:22.000000000 +0100
> +@@ -21,7 +21,7 @@
> + BINDIR   = $(PREFIX)/bin
> + LOCDIR   = ./locale
> + LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype -lfontconfig
> +-INCLUDES = -I/usr/include/freetype2
> ++INCLUDES = -I/srv/oe/angstrom-dev/staging/armv7a-angstrom-linux-gnueabi/usr/include/freetype2

Maybe you've overlooked that, but it's unacceptable hardcoded path...

-- ynezz