All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: linville@tuxdriver.com, users@rt2x00.serialmonkey.com,
	linux-wireless@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 2.6.33] rt2x00: Disable powersaving for rt61pci.
Date: Sun, 13 Dec 2009 16:18:49 +0100	[thread overview]
Message-ID: <200912131618.49312.IvDoorn@gmail.com> (raw)
In-Reply-To: <4B250567.8050809@gmail.com>

On Sunday 13 December 2009, Gertjan van Wingerde wrote:
> On 12/13/09 11:15, Ivo van Doorn wrote:
> > On Sunday 13 December 2009, Gertjan van Wingerde wrote:
> >> We've had many reports of rt61pci failures with powersaving enabled.
> >> Therefore, as a stop-gap measure, disable powersaving of the rt61pci
> >> until we have found a proper solution.
> > 
> > This disables powersaving completely, can't we set the default powersaving
> > to disabled? That way for people for who it does work, it can still be enabled.
> > 
> 
> Well, when I was looking into this I came up with a number of issues in the code
> which makes me believe that it simply isn't working at all.
> One example is that the rt61pci devices rely on handling the wakeup interrupt
> by the driver to wake up the devices. As far as I can tell there is no handling
> of the wakeup interrupt in the rt61pci driver.
> That's why I decided to disable it all together, as I don't think it works
> properly for anyone (although some people may not really notice it).

Ok, but then please disable it for _all_ rt2x00 drivers, or at least all PCI rt2x00 drivers
since they would have the same wakeup interrupt requirement.

Ivo

  reply	other threads:[~2009-12-13 15:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-12 23:39 [PATCH 2.6.33] rt2x00: Fix rt2800usb detection in rt2800lib Gertjan van Wingerde
2009-12-12 23:39 ` [PATCH 2.6.33] rt2x00: Disable powersaving for rt61pci Gertjan van Wingerde
2009-12-13 10:15   ` Ivo van Doorn
2009-12-13 15:16     ` Gertjan van Wingerde
2009-12-13 15:18       ` Ivo van Doorn [this message]
2009-12-13 15:21         ` Gertjan van Wingerde
2009-12-13 15:45           ` [rt2x00-users] " Benoit PAPILLAULT
2009-12-14 19:27           ` Gertjan van Wingerde
2009-12-13  3:54 ` [PATCH 2.6.33] rt2x00: Fix rt2800usb detection in rt2800lib Randy Dunlap
2009-12-13 10:14 ` Ivo van Doorn
2009-12-14 19:13 ` [PATCH] " John W. Linville
2009-12-14 19:24   ` Gertjan van Wingerde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200912131618.49312.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=gwingerde@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=stable@kernel.org \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.