From: Frederic Weisbecker <fweisbec@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:tracing/urgent] ftrace.h: Use common pr_info fmt string
Date: Sun, 13 Dec 2009 22:24:51 +0100 [thread overview]
Message-ID: <20091213212450.GB5220@nowhere> (raw)
In-Reply-To: <1260729207.8189.56.camel@Joe-Laptop.home>
On Sun, Dec 13, 2009 at 10:33:27AM -0800, Joe Perches wrote:
> On Sun, 2009-12-13 at 15:50 +0100, Frederic Weisbecker wrote:
> > On Sun, Dec 13, 2009 at 09:48:15AM -0500, Steven Rostedt wrote:
> > > > pr_info("event trace: Could not activate trace point " \
> > > > - "probe to " #call "\n"); \
> > > > + "probe to %s\n", #call); \
> > > This reduces format string space a bit, but doesn't it just add another
> > > string to the string tables #func == "func" as well as add code to pass
> > > in another parameter?
> > Yeah, I don't understand the purpose of this patch either...
>
> The patch from Li Zefan you've already queued is better
>
> http://lkml.org/lkml/2009/12/13/60
Ok. Thanks.
prev parent reply other threads:[~2009-12-13 21:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 21:06 [PATCH] ftrace.h: Use common pr_info fmt string Joe Perches
2009-12-13 7:37 ` [tip:tracing/urgent] " tip-bot for Joe Perches
[not found] ` <1260715695.2146.412.camel@gandalf.stny.rr.com>
2009-12-13 14:50 ` Frederic Weisbecker
2009-12-13 17:53 ` Joe Perches
2009-12-13 18:33 ` Joe Perches
2009-12-13 21:24 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091213212450.GB5220@nowhere \
--to=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.