Re: [PATCH] keymap: support for force_release quirk

[Martin Pitt <martin.pitt@ubuntu.com>]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

Hello Johannes,

Johannes Stezenbach [2009-12-14 13:37 +0100]:
> I don't understand.  I only append to the force_release attribute
> because the kernel already removes duplicates.

Oh, indeed it does:

$ cat /sys/devices/platform/i8042/serio0/force_release
133-139,143,147,369-370

$ echo '133-139,143,147,369-370,143,147,370,371,147,371' | sudo tee /sys/devices/platform/i8042/serio0/force_release
$ cat /sys/devices/platform/i8042/serio0/force_release
133-139,143,147,369-371

So indeed we then don't need to worry about sending duplicate keys.
Nice!

> However, what does not work this way is to remove scancodes from
> force_release. I thought that was what Martin wanted to accomplish
> on the "change" event.

Hm, it seems to work just fine here:

$ echo 133 | sudo tee /sys/devices/platform/i8042/serio0/force_release133
$ cat /sys/devices/platform/i8042/serio0/force_release
133

So it seems every time you write the file you have to do it completely
(or read the original one).

So I think your approach is fine after all, and we just need the other
small cleanups.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]