From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 03/11] pci: s/PCI_SUBVENDOR_ID/PCI_SUBSYSTEM_VENDOR_ID/g
Date: Mon, 14 Dec 2009 15:36:32 +0200 [thread overview]
Message-ID: <20091214133632.GE973@redhat.com> (raw)
In-Reply-To: <1260794906-30168-4-git-send-email-yamahata@valinux.co.jp>
On Mon, Dec 14, 2009 at 09:48:18PM +0900, Isaku Yamahata wrote:
> To match Linux PCI register definition,
> rename PCI_SUBVENDOR_ID to PCI_SUBSYSTEM_VENDOR_ID.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/pci.c | 2 +-
> hw/pci.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index 344d72b..fb03ee2 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -411,7 +411,7 @@ static int pci_set_default_subsystem_id(PCIDevice *pci_dev)
> {
> uint16_t *id;
>
> - id = (void*)(&pci_dev->config[PCI_SUBVENDOR_ID]);
> + id = (void*)(&pci_dev->config[PCI_SUBSYSTEM_VENDOR_ID]);
> id[0] = cpu_to_le16(pci_default_sub_vendor_id);
> id[1] = cpu_to_le16(pci_default_sub_device_id);
> return 0;
> diff --git a/hw/pci.h b/hw/pci.h
> index d279e3f..0309674 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -155,7 +155,7 @@ typedef struct PCIIORegion {
> #define PCI_CAP_LIST_NEXT 1 /* Next capability in the list */
>
> #define PCI_REVISION 0x08 /* obsolete, use PCI_REVISION_ID */
> -#define PCI_SUBVENDOR_ID 0x2c /* obsolete, use PCI_SUBSYSTEM_VENDOR_ID */
> +#define PCI_SUBSYSTEM_VENDOR_ID 0x2c
> #define PCI_SUBDEVICE_ID 0x2e /* obsolete, use PCI_SUBSYSTEM_ID */
>
> /* Bits in the PCI Status Register (PCI 2.3 spec) */
> --
> 1.6.5.4
next prev parent reply other threads:[~2009-12-14 13:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 12:48 [Qemu-devel] [PATCH 00/11] various pci clean ups Isaku Yamahata
2009-12-14 12:48 ` [Qemu-devel] [PATCH 01/11] pci: remove PCIBus::config_reg Isaku Yamahata
2009-12-14 13:51 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 02/11] pci: clean up pci_bar_address() Isaku Yamahata
2009-12-14 13:36 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 03/11] pci: s/PCI_SUBVENDOR_ID/PCI_SUBSYSTEM_VENDOR_ID/g Isaku Yamahata
2009-12-14 13:36 ` Michael S. Tsirkin [this message]
2009-12-14 12:48 ` [Qemu-devel] [PATCH 04/11] pci: remove PCI_REVISION and PCI_SUBDEVICE_ID Isaku Yamahata
2009-12-14 13:53 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 05/11] pci: import Linux pci_regs.h Isaku Yamahata
2009-12-14 12:48 ` [Qemu-devel] [PATCH 06/11] pci: use pci_regs.h Isaku Yamahata
2009-12-14 13:37 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 07/11] gt64xxx: remove gt64120_{read, write}_config() Isaku Yamahata
2009-12-14 13:51 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 08/11] acpi: use range helper function Isaku Yamahata
2009-12-14 13:37 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 09/11] piix_pci: define symbolic value for PAM0, PAM6 and SMRAM Isaku Yamahata
2009-12-14 13:49 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 10/11] piix_pci: use range helper function Isaku Yamahata
2009-12-14 13:50 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 12:48 ` [Qemu-devel] [PATCH 11/11] msix: " Isaku Yamahata
2009-12-14 13:25 ` [Qemu-devel] " Michael S. Tsirkin
2009-12-14 13:54 ` [Qemu-devel] Re: [PATCH 00/11] various pci clean ups Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091214133632.GE973@redhat.com \
--to=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.