From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Ajay Kumar Gupta <ajay.gupta@ti.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
"david-b@pacbell.net" <david-b@pacbell.net>
Subject: Re: [PATCH 3/3] musb: Add 'extvbus' in musb_hdrc_platform_data
Date: Mon, 14 Dec 2009 18:37:46 +0200 [thread overview]
Message-ID: <20091214163746.GC31829@nokia.com> (raw)
In-Reply-To: <1260797982-28880-3-git-send-email-ajay.gupta@ti.com>
Hi,
On Mon, Dec 14, 2009 at 02:39:42PM +0100, ext Ajay Kumar Gupta wrote:
>diff --git a/drivers/usb/musb/musb_regs.h b/drivers/usb/musb/musb_regs.h
>index 8ca8f23..cba724d 100644
>--- a/drivers/usb/musb/musb_regs.h
>+++ b/drivers/usb/musb/musb_regs.h
>@@ -72,6 +72,10 @@
> #define MUSB_DEVCTL_HR 0x02
> #define MUSB_DEVCTL_SESSION 0x01
>
>+/* ULPI VBUSCONTROL */
>+#define ULPI_USE_EXTVBUS 0x01
>+#define ULPI_USE_EXTVBUSIND 0x02
shouldn't these go to drivers/usb/otg/ulpi.c or include/usb/ulpi.h ?
or is this musb specific ?? If it's musb specific, please prepend with
MUSB_
--
balbi
next prev parent reply other threads:[~2009-12-14 16:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 13:39 [PATCH 1/3] musb: save dynfifo in musb struct Ajay Kumar Gupta
[not found] ` <1260797982-28880-1-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2009-12-14 13:39 ` [PATCH 2/3 v3] musb: Add context save and restore support Ajay Kumar Gupta
2009-12-14 13:39 ` [PATCH 3/3] musb: Add 'extvbus' in musb_hdrc_platform_data Ajay Kumar Gupta
2009-12-14 16:37 ` Felipe Balbi [this message]
[not found] ` <20091214163746.GC31829-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-15 4:07 ` Gupta, Ajay Kumar
[not found] ` <1260797982-28880-2-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2009-12-14 16:33 ` [PATCH 2/3 v3] musb: Add context save and restore support Felipe Balbi
2009-12-14 16:39 ` Felipe Balbi
[not found] ` <20091214163324.GB31829-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-15 11:44 ` Gupta, Ajay Kumar
[not found] ` <19F8576C6E063C45BE387C64729E739404372AAF0F-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-12-15 12:04 ` Gadiyar, Anand
[not found] ` <5A47E75E594F054BAF48C5E4FC4B92AB030ADD53A6-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-12-15 12:10 ` Felipe Balbi
[not found] ` <20091215121032.GH3689-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-15 12:36 ` Gupta, Ajay Kumar
[not found] ` <19F8576C6E063C45BE387C64729E739404372AAF44-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-12-15 12:39 ` Gupta, Ajay Kumar
2009-12-15 12:48 ` Felipe Balbi
2009-12-17 13:38 ` Arnaud Mandy
2009-12-17 13:51 ` Gupta, Ajay Kumar
[not found] ` <19F8576C6E063C45BE387C64729E73940449F439C7-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-12-17 14:10 ` Arnaud Mandy
[not found] ` <4B2A3BEE.7000809-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-17 14:16 ` Gupta, Ajay Kumar
[not found] ` <19F8576C6E063C45BE387C64729E73940449F439D9-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-12-17 15:17 ` Arnaud Mandy
[not found] ` <4B2A4BA6.9010804-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-18 4:17 ` Gupta, Ajay Kumar
2009-12-14 16:24 ` [PATCH 1/3] musb: save dynfifo in musb struct Felipe Balbi
2009-12-15 4:04 ` Gupta, Ajay Kumar
[not found] ` <19F8576C6E063C45BE387C64729E739404372AAD03-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-12-15 7:26 ` Felipe Balbi
2009-12-15 7:37 ` Gupta, Ajay Kumar
[not found] ` <19F8576C6E063C45BE387C64729E739404372AAE01-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-12-15 7:40 ` Felipe Balbi
[not found] ` <20091215074025.GB3147-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2009-12-15 7:44 ` Gupta, Ajay Kumar
2009-12-15 8:32 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091214163746.GC31829@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=ajay.gupta@ti.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.