All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>,
	"Varadarajan, Charu Latha" <charu@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@nokia.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v7 2/5] OMAP: McBSP: Modify macros/functions API for easy cache access
Date: Mon, 14 Dec 2009 11:36:05 -0800	[thread overview]
Message-ID: <20091214193605.GC4575@atomide.com> (raw)
In-Reply-To: <20091214131433.5c9b26a6.jhnikula@gmail.com>

* Jarkko Nikula <jhnikula@gmail.com> [091214 03:12]:
> On Mon, 14 Dec 2009 11:11:27 +0100
> Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:
> 
> > If these functions are obsolete and going to be removed, I don't think it 
> > could be of any importance whether they are modified before removal or not. 
> > Otherwise, a solution seems simple to me: you submit a patch that addresses 
> > all concearns, yours, Tony's (BTW, have you already reviewed the drivers as 
> > Tony suggested?), maybe others. Then, after your patch is accepted for 
> > inclusion and it appears in conflict with this series still not applied for 
> > any reason (possibly waiting for your changes if that decided), Jarkko, or 
> > Tony, or anyone else pointed out by Tony, decides which one goes first and 
> > which is going to be refreshed on top of the other. Does it sound like a good 
> > plan for you?
> > 
> I would favor the Janusz's set going in first since it will solve and
> help the in-tree problems without making out-of-tree use any worse than
> currently.
> 
> - Fixes register access in polled I/O functions (out-of-tree use)
> - Fixes McBSP register corruption noted on Amstrad Delta
> - McBSP register caching could help the PM development
> 
> Fixing any other issues in polled I/O API belongs to another context
> than this patch set and IMO is easier to handle after this set since the
> patch 1/5 already fixes the register access width.

Sounds good to me.

Tony

  reply	other threads:[~2009-12-14 19:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-09 20:24 [PATCH v7 0/5] OMAP: McBSP: Use register cache Janusz Krzysztofik
2009-12-09 20:27 ` [PATCH v7 1/5] OMAP: McBSP: Use macros for all register read/write operations Janusz Krzysztofik
2009-12-09 20:29 ` [PATCH v7 2/5] OMAP: McBSP: Modify macros/functions API for easy cache access Janusz Krzysztofik
2009-12-09 20:40   ` [PATCH v7 2/5] [Resend] " Janusz Krzysztofik
2009-12-11 14:10   ` [PATCH v7 2/5] " Varadarajan, Charu Latha
2009-12-11 15:42     ` Janusz Krzysztofik
2009-12-14  6:05       ` Varadarajan, Charu Latha
2009-12-14 10:11         ` Janusz Krzysztofik
2009-12-14 11:14           ` Jarkko Nikula
2009-12-14 19:36             ` Tony Lindgren [this message]
2009-12-22  8:58               ` Varadarajan, Charu Latha
2010-01-06 12:03                 ` Janusz Krzysztofik
2009-12-09 20:31 ` [PATCH v7 3/5] OMAP: McBSP: Introduce caching in register write operations Janusz Krzysztofik
2009-12-11 13:11   ` Jarkko Nikula
2009-12-11 13:51     ` Janusz Krzysztofik
2009-12-15  0:36       ` [PATCH 3/5 v8] " Janusz Krzysztofik
2009-12-16  8:12         ` Jarkko Nikula
2009-12-09 20:33 ` [PATCH v7 4/5] OMAP: McBSP: Use cache when modifying individual register bits Janusz Krzysztofik
2009-12-09 20:34 ` [PATCH v7 5/5] OMAP: McBSP: Split and move read/write functions to mach-omap1/2 Janusz Krzysztofik
2009-12-11 13:21   ` Jarkko Nikula
2009-12-11 13:57     ` Janusz Krzysztofik
2009-12-16  8:02 ` [PATCH v7 0/5] OMAP: McBSP: Use register cache Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091214193605.GC4575@atomide.com \
    --to=tony@atomide.com \
    --cc=charu@ti.com \
    --cc=jhnikula@gmail.com \
    --cc=jkrzyszt@tis.icnet.pl \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.