From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 14 Dec 2009 21:44:32 +0100 Subject: [U-Boot] [PATCH] ppc4xx: Canyonlands: Fix USB host PHY reset sequence In-Reply-To: <1260821359-8705-1-git-send-email-dmitchell@appliedmicro.com> References: <1260821359-8705-1-git-send-email-dmitchell@appliedmicro.com> Message-ID: <20091214204432.372AD4C026@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stefan, In message <1260821359-8705-1-git-send-email-dmitchell@appliedmicro.com> Dave Mitchell wrote: ... > --- a/board/amcc/canyonlands/canyonlands.c > +++ b/board/amcc/canyonlands/canyonlands.c > @@ -177,8 +177,11 @@ int board_early_init_f(void) > /* Remove NOR-FLASH, NAND-FLASH & EEPROM hardware write protection */ > out_8((void *)CONFIG_SYS_BCSR_BASE + 5, 0); > > - /* Enable USB host & USB-OTG */ > + /* Enable USB host & USB-OTG;force assert,then de-assert PHY reset */ > + out_8((void *)CONFIG_SYS_BCSR_BASE + 7, 1); > + mdelay(100); > out_8((void *)CONFIG_SYS_BCSR_BASE + 7, 0); > + mdealy(100); We should get rid of this "CONFIG_SYS_BCSR_BASE + offset" stuff and use a proper C struct for this. What do you think? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Testing can show the presense of bugs, but not their absence. -- Edsger Dijkstra