All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: mingo@redhat.com, hpa@zytor.com, paulus@samba.org,
	linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	efault@gmx.de, tglx@linutronix.de, mhiramat@redhat.com,
	mingo@elte.hu, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf symbols: Allow lookups by symbol name too
Date: Tue, 15 Dec 2009 03:32:30 +0100	[thread overview]
Message-ID: <20091215023228.GC6048@nowhere> (raw)
In-Reply-To: <20091215022020.GD21796@ghostprotocols.net>

On Tue, Dec 15, 2009 at 12:20:20AM -0200, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 15, 2009 at 03:12:03AM +0100, Frederic Weisbecker escreveu:
> > On Sat, Dec 12, 2009 at 07:22:03AM +0000, tip-bot for Arnaldo Carvalho de Melo wrote:
> > > Looking over the vmlinux/kallsyms is common enough that I'll add a
> > > variable to the upcoming struct perf_session to avoid the need to
> > > use map_groups__find_by_name to get the main vmlinux/kallsyms map.
> > > 
> > > The above example looks on the 'variable' symtab, but it is just
> > > like that for the functions one.
> > > 
> > > Also the sort operation is done when we first use
> > > map__find_symbol_by_name, in a lazy way.
> > 
> > It would be nice to also have a kernel symbol resolution
> > helper independant of any session.
> > 
> > The problem is that I need to resolve a kernel variable symbol
> > very early, when we parse record options. We don't have any
> > session at this time so I can't retrieve the kmaps.
> 
> Humm, I don't think that is a problem, we just have to create the
> session before processing the args, after all at record time we can use
> kallsyms already.



Yeah but we need the output filename before creating it, which
we even don't have yet at this time.

May be I should just init it very early without the filename
and assign it later with a small new helper.

Another problem is that the record session is not available
from parse-events.c, may be should I create a single wide scope
record_session that would be shared among record, top and stat
so that it's available from parse-event.c


> 
> > I'm not sure what's the proper way to handle that.
> 
> What is the problem? I'm not following :-)


I think the real problem actually is that I should join
my bed.
The above questions will retrieve their trivial essence after
some sleep :)


  reply	other threads:[~2009-12-15  2:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 20:50 [PATCH 1/1] perf symbols: Allow lookups by symbol name too Arnaldo Carvalho de Melo
2009-12-14 11:21 ` Frederic Weisbecker
     [not found] ` <tip-79406cd789f745ac6aa9d597895f904a98a14007@git.kernel.org>
2009-12-15  2:12   ` [tip:perf/urgent] " Frederic Weisbecker
2009-12-15  2:20     ` Arnaldo Carvalho de Melo
2009-12-15  2:32       ` Frederic Weisbecker [this message]
2009-12-15  2:44         ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091215023228.GC6048@nowhere \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=efault@gmx.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.